Repository navigation
fix(glitch-invaders): fix the UX review's start error, console overflow, and LIVE badge - #39
Conversation
…ow, and LIVE badge
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
theycallmeswift
left a comment
There was a problem hiding this comment.
Orchestrator review of dbcaebe, merged with current main: clean. verify (4 packages), npm test (299) and lint pass. Spot-checked in headless Chrome at 1000×597: 0 DOM mutations in 3 s at intro and in idle play, the pads, Skip ahead, Reset and badge are all within 597 px, and the state line stays in the accessibility tree. All nine issue items are covered. The done_when rewording is valid against the contract and matches monitor/SKILL.md.
Decide items:
- Station issue for the lag during combat: no new issue needed. The 8 s quiet / 22 s cap is BS-BROW-5 as specced, and MLH/boothstrap.sh#623 ("Check browser challenge steps sooner after the page changes") already tracks shortening it.
- A tap moves one lane: sound.
- CSS-text layout guards: fine as a stopgap until a browser test tier exists.
- Reworded
done_when: sound.
Nits, for a follow-up:
- The CSS-text guards in
test/glitch-invaders.test.mjsbreak on harmless restyles and miss real overlaps. Replace them with a headless-Chrome layout check when the repo gets a browser tier. diagnosePane()inincident-console.mjssetsthis.newestHintwhile it builds DOM. Return it with{ content, actions }instead.
Generated by Claude Code
Fixes the Glitch Invaders findings from the 2026-11-01 challenge UX review (closes #32). Setup now seeds an unplayed
glitch-progress.json, so Pi's first read no longer fails. The Incident Console scrolls inside a viewport-bounded panel with its actions pinned. The mode badge follows the evidence source. A pad tap moves one lane. Toasts sit at the top of the arena and clear after 2.5 s. The end card points to the debrief. Pi saves questions for when an incident closes. Theglitch-stateline is visually hidden but stays in the accessibility tree.Station step-check lag: the cause was in the package.
Hud.updaterewrote#stat-shield'sdata-stateevery frame (about 60 mutation records a second), so the station's 8 s quiet period never elapsed and every check waited for its 22 s cap. DOM writes from the frame loop now happen only on change. In Chromium the page now records 0 mutations a second at intro, in idle play, while paused, and with the console open. Onmainit records about 60.Decide
styles.cssandindex.htmlas text, because the repo has no browser test tier. The 597 px fit itself was measured in Chromium, below. Recommend: keep them until a browser tier exists, because they're the only check that fails if the pinned-actions structure is removed.done_whenfor the four game steps now says the state line is in the page's accessibility snapshot, not that the page "shows" it. Recommend: keep it, because the line is no longer on screen and the monitor reads the snapshot.Ready gate
npm run verify: ok on all 4 packages.npm test: 286 pass, 0 fail.npm run lint: 0 issues in 18 files.setStylecache, the end-card line, toast placement, and the state-line class. ThereleaseAlltest is extra coverage with no fix behind it.state-line. Updated the package README,monitor/SKILL.mdand the fourdone_whenlines. No.spaceror.state-linerules are left.README.md(setup seeds progress, hidden state line),monitor/SKILL.md,skills/start-challenge/SKILL.md. Repodocs/unchanged, because the architecture didn't change.google/gemini-3.8-flash. Setup exited 0, the server answered 200, and an unplayed progress file was present. Pi's first tool call read it with no error. Start in Chromium setlaunched=yesin the state line and the file. Follow-up nudges asked no questions. Cleanup exited 0, stopped the server and emptied the workspace.docs/style/. Split multi-exercise tests into one exercise each, removed a constant-only test and a duplicate assertion, and removed the skill's contradiction about when to ask questions.Layout at a 597 px tall viewport, measured in Chromium: every console stage's action, the pads, Skip ahead, both Reset buttons and the end card's buttons are in view and clickable at 1000 and 800 px wide (96 of 96 checks pass). Continue to Diagnose moved from 659 px to 550 px. The topbar stays on one row at 1000 px (38 px tall), with the mode badge visible down to 760 px.
Generated by Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.