Repository navigation
fix(hello-world): name typo corrections, introduce Pi, and drop the Intro's doubled punctuation - #38
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
theycallmeswift
commented
Nov 2, 2026
theycallmeswift
left a comment
Contributor
Author
There was a problem hiding this comment.
Orchestrator review of d3e0b70, merged with current main: clean. verify (4 packages), npm test (277) and lint pass, and both new tests fail with main's intro.md and SKILL.md. All three items from #35 are in, and nothing tells the attendee to press Finish (out of scope). The new "I'm Pi, your guide." opener doesn't clash with the base skill's greeting by name.
Nit, left for the merger:
test/hello-world.test.mjs: the new test copies the skill read from the test above it. Per the "DRY early" rule indocs/style/development.md, extract areadSkillhelper next toreadManifestand call it from both.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35. The Hello, World! skill now opens with "I'm Pi, your guide." and names a corrected file name ("I think you meant
welcome.txt"). The Intro ends on Hello, world! with no trailing period, so it no longer renders "Hello, world!." To make that work, "No terminal experience needed." moves up to the second sentence.Decide
Nothing.
Ready gate
npm run verify: ok for all 4 packages.npm test: 266 pass, 0 fail.npm run lint: 0 issues.main'sintro.mdandSKILL.md, both new tests intest/hello-world.test.mjsfail: the Intro has no doubled punctuation once markup is stripped, and the skill has Pi introduce itself and name a corrected file name. Both pass with this change.Hello, worldandhello-worldoutside the package. The only hits are the README index tagline and test plumbing, and neither quotes the changed wording.google/gemini-3.8-flash. Pi opened with "I'm Pi, your guide." Asked to readwelcom.txt, it replied "I think you meantwelcome.txt!" and greeted. It then createdhello.txtwithHello, world!and read it back. It named both steps and congratulated.cleanupremovedwelcome.txtand kepthello.txt.docs/style/. Acted on: added a test for the two skill changes and narrowed the punctuation regex to the bug. Kept: moving the "No terminal experience needed." sentence.Generated by Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.