Skip to content

fix(hello-world): name typo corrections, introduce Pi, and drop the Intro's doubled punctuation - #38

Merged
theycallmeswift merged 2 commits into
mainfrom
fix/hello-world-ux-polish
Nov 2, 2026
Merged

theycallmeswift merged 2 commits into
mainfrom
fix/hello-world-ux-polish

Conversation

@theycallmeswift

@theycallmeswift theycallmeswift commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Closes #35. The Hello, World! skill now opens with "I'm Pi, your guide." and names a corrected file name ("I think you meant welcome.txt"). The Intro ends on Hello, world! with no trailing period, so it no longer renders "Hello, world!." To make that work, "No terminal experience needed." moves up to the second sentence.

Decide

Nothing.

Ready gate

Step Evidence
Tests and lint npm run verify: ok for all 4 packages. npm test: 266 pass, 0 fail. npm run lint: 0 issues. ✅
Red run With main's intro.md and SKILL.md, both new tests in test/hello-world.test.mjs fail: the Intro has no doubled punctuation once markup is stripped, and the skill has Pi introduce itself and name a corrected file name. Both pass with this change. ✅
Sibling sweep Searched the repo for Hello, world and hello-world outside the package. The only hits are the README index tagline and test plumbing, and neither quotes the changed wording. ✅
Docs and specs None. The package README's standalone flow is unchanged and quotes neither the Intro nor the skill. ✅
Standalone run Ran the package README's flow with Pi 1.0.4, pi-mcp-adapter 5.2.0 and google/gemini-3.8-flash. Pi opened with "I'm Pi, your guide." Asked to read welcom.txt, it replied "I think you meant welcome.txt!" and greeted. It then created hello.txt with Hello, world! and read it back. It named both steps and congratulated. cleanup removed welcome.txt and kept hello.txt. ✅
Editorial pass A separate reviewer checked the diff against #35 and docs/style/. Acted on: added a test for the two skill changes and narrowed the punctuation regex to the bug. Kept: moving the "No terminal experience needed." sentence. ✅
Skipped tests None. ✅
Secrets, permissions Not touched. ✅

Generated by Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1a701d9c-dd63-4f15-9d37-09ff1df045b5
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@theycallmeswift theycallmeswift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orchestrator review of d3e0b70, merged with current main: clean. verify (4 packages), npm test (277) and lint pass, and both new tests fail with main's intro.md and SKILL.md. All three items from #35 are in, and nothing tells the attendee to press Finish (out of scope). The new "I'm Pi, your guide." opener doesn't clash with the base skill's greeting by name.

Nit, left for the merger:

  • test/hello-world.test.mjs: the new test copies the skill read from the test above it. Per the "DRY early" rule in docs/style/development.md, extract a readSkill helper next to readManifest and call it from both.

Generated by Claude Code

@theycallmeswift
theycallmeswift marked this pull request as ready for review November 2, 2026 04:40
@theycallmeswift theycallmeswift self-assigned this Nov 2, 2026
@theycallmeswift
theycallmeswift merged commit 0b17cfb into main Nov 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hello, World!: polish the skill and Intro from the UX review

2 participants