Repository navigation
fix(vibe-coding-mad-libs): match preview wording to show_preview outcomes and fix the form's review issues - #37
Conversation
…omes and fix the form's review issues
Name the dice option Roll dice everywhere, keep the dice view's back hint and whole rolls visible at narrow widths, word the form fallback as something Pi can see, say previews are offered, and fix the standalone snippet's package path.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
Orchestrator: back to draft for one scope fix while the full review runs. Please drop the Generated by Claude Code |
theycallmeswift
left a comment
There was a problem hiding this comment.
Orchestrator review of 350c232 plus the scope fix in 4737a66: clean. verify (4 packages), npm test (275) and lint pass. dice.mjs and the challenge.json hint change are valid against the contract, add no dependencies, and are in scope.
Decide items:
navigated, notopened: correct. The spec'sshow_previewrow and boothstrap's control contract only returnofferedornavigated.- Roll dice shows the dice sheet rather than rolling: right. It matches the UX review's suggestion (#6) and the skill's "never pretend you rolled".
Nit, left for the merger:
challenges/vibe-coding-mad-libs/skills/start-challenge/SKILL.md: the skill no longer mentions/mad-libs. If a participant presses Esc and then asks Pi how to get back to the form, Pi doesn't know; only the extension's toast says so. Suggest adding "then say/mad-libsreopens the form." after "show its four tables as they are".
Generated by Claude Code
Fixes #34. The Mad Libs skill now words the preview by
show_previewoutcome, so Pi stops claiming a preview is open while the dialog waits. The form draws placeholders muted, shows a cursor only in the focused field, and gains a Roll dice view read fromdice-sheet.md, replacing the Esc / ask Pi //mad-libsdetour. The welcome is two sentences.Decide
openedandoffered; the station returnsofferedandnavigated(spec'sshow_previewrow). The skill usesnavigated. Recommend: keepnavigated, because it is the value Pi actually receives.Ready gate
npm run verify: ok on all four packages.npm test: 275 pass, 0 fail.npm run lint: 0 issues in 18 files.tinstead of<muted>; cursor test saw a cursor in all four fields; Esc in the dice view closed the form; the 40-column test saw a truncated back hint and a line starting with·; the 16-column test saw "Exhausted night-shift nurses" cut.grep -rln show_preview challenges: Mad Libs skill and README updated; BirdsBirdBirds' skill is left to #36 (for #33).grepfor the old dice detour: no hits left.README.md,intro.md,challenge.jsonhint, skill. No repodocs/change: no architecture change.setupcopieddice-sheet.mdand served the waiting page on :4321. Pi 1.0.4 with Gemini loadedstart-challengeandmad-libs.mjswithout errors. Given the filled sentence, Pi wrote a workingindex.htmland, with noshow_preview, gave the URL without claiming the preview opened. In the TUI: two-sentence welcome, then the form with faint placeholders, one reverse-video cursor in the focused field, "Fill in Theme first." on an empty Build, and Roll dice listing all four tables.cleanupstopped the preview.docs/style/; welcome cut to two sentences, one name ("Roll dice") everywhere, overclaiming "shows" changed to "offers".