Skip to content

fix(vibe-coding-mad-libs): match preview wording to show_preview outcomes and fix the form's review issues - #37

Merged
theycallmeswift merged 4 commits into
mainfrom
fix/mad-libs-ux-review-34
Nov 2, 2026
Merged

theycallmeswift merged 4 commits into
mainfrom
fix/mad-libs-ux-review-34

Conversation

@theycallmeswift

@theycallmeswift theycallmeswift commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #34. The Mad Libs skill now words the preview by show_preview outcome, so Pi stops claiming a preview is open while the dialog waits. The form draws placeholders muted, shows a cursor only in the focused field, and gains a Roll dice view read from dice-sheet.md, replacing the Esc / ask Pi / /mad-libs detour. The welcome is two sentences.

Decide

  • The issue names the outcomes opened and offered; the station returns offered and navigated (spec's show_preview row). The skill uses navigated. Recommend: keep navigated, because it is the value Pi actually receives.
  • Roll dice shows the four tables inside the form; it does not roll for the attendee, since the booth's dice are physical and the skill forbids pretending to roll. Recommend: keep it a lookup view, because a virtual roll would contradict the booth setup.

Ready gate

Step Evidence
Tests and lint npm run verify: ok on all four packages. npm test: 275 pass, 0 fail. npm run lint: 0 issues in 18 files.
Red run Before each fix: placeholder test got reverse-video t instead of <muted>; cursor test saw a cursor in all four fields; Esc in the dice view closed the form; the 40-column test saw a truncated back hint and a line starting with ·; the 16-column test saw "Exhausted night-shift nurses" cut.
Sibling sweep grep -rln show_preview challenges: Mad Libs skill and README updated; BirdsBirdBirds' skill is left to #36 (for #33). grep for the old dice detour: no hits left.
Docs and specs Package README.md, intro.md, challenge.json hint, skill. No repo docs/ change: no architecture change.
Standalone run setup copied dice-sheet.md and served the waiting page on :4321. Pi 1.0.4 with Gemini loaded start-challenge and mad-libs.mjs without errors. Given the filled sentence, Pi wrote a working index.html and, with no show_preview, gave the URL without claiming the preview opened. In the TUI: two-sentence welcome, then the form with faint placeholders, one reverse-video cursor in the focused field, "Fill in Theme first." on an empty Build, and Roll dice listing all four tables. cleanup stopped the preview.
Editorial pass Reread against docs/style/; welcome cut to two sentences, one name ("Roll dice") everywhere, overclaiming "shows" changed to "offers".
Skipped tests None.
Secrets, permissions Not touched.

Name the dice option Roll dice everywhere, keep the dice view's back hint
and whole rolls visible at narrow widths, word the form fallback as
something Pi can see, say previews are offered, and fix the standalone
snippet's package path.
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 85e86c8a-73ce-44aa-8fb6-a44bf40a4fc2
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@theycallmeswift
theycallmeswift marked this pull request as ready for review November 2, 2026 04:32
@theycallmeswift
theycallmeswift marked this pull request as draft November 2, 2026 04:32

Copy link
Copy Markdown
Contributor Author

Orchestrator: back to draft for one scope fix while the full review runs.

Please drop the challenges/birdsbirdbirds/ changes (README.md and skills/start-challenge/SKILL.md) from this PR. Issue #34 covers Mad Libs only. #36 (for #33) already fixes the BirdsBirdBirds preview wording, and the two PRs conflict on that skill as they stand. Restore those two files to main's version in a new commit (no force-push). If you think something in them isn't covered by #36, put it in your report rather than the diff.


Generated by Claude Code

@theycallmeswift theycallmeswift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orchestrator review of 350c232 plus the scope fix in 4737a66: clean. verify (4 packages), npm test (275) and lint pass. dice.mjs and the challenge.json hint change are valid against the contract, add no dependencies, and are in scope.

Decide items:

  • navigated, not opened: correct. The spec's show_preview row and boothstrap's control contract only return offered or navigated.
  • Roll dice shows the dice sheet rather than rolling: right. It matches the UX review's suggestion (#6) and the skill's "never pretend you rolled".

Nit, left for the merger:

  • challenges/vibe-coding-mad-libs/skills/start-challenge/SKILL.md: the skill no longer mentions /mad-libs. If a participant presses Esc and then asks Pi how to get back to the form, Pi doesn't know; only the extension's toast says so. Suggest adding "then say /mad-libs reopens the form." after "show its four tables as they are".

Generated by Claude Code

@theycallmeswift
theycallmeswift marked this pull request as ready for review November 2, 2026 04:37
@theycallmeswift theycallmeswift self-assigned this Nov 2, 2026
@theycallmeswift
theycallmeswift merged commit 7cbe8bf into main Nov 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vibe Coding Mad Libs: stop claiming the preview is open, and fix the review's form issues

2 participants