Skip to content

fix: treat SURGICAL SAME DAY ADMISSION as elective surgery #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: treat SURGICAL SAME DAY ADMISSION as elective surgery #2133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c30bffe
fix: treat SURGICAL SAME DAY ADMISSION as elective surgery
Chessing234 Jul 29, 2026
61c5606
style: wrap elective admission_type IN lists for sqlfluff
Chessing234 Jul 29, 2026
8f6b331
ci: don't fail fork PRs on sqlfluff annotate permissions
Chessing234 Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/lint_sqlfluff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,12 @@ jobs:
shell: bash
run: sqlfluff lint --format github-annotation --annotation-level failure --nofail ${{ steps.get_files_to_lint.outputs.lintees }} > annotations.json
- name: Annotate
# Fork PRs cannot create check runs with GITHUB_TOKEN; lint already ran.
continue-on-error: true
if: steps.get_files_to_lint.outputs.lintees != ''
uses: yuzutech/annotations-action@v0.6.0
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
title: "SQLFluff Lint"
input: "./annotations.json"
input: "./annotations.json"
ignore-missing-file: true
4 changes: 3 additions & 1 deletion mimic-iv/concepts/score/oasis.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@ WITH surgflag AS (
, uo.urineoutput

, CASE
WHEN adm.admission_type = 'ELECTIVE' AND sf.surgical = 1
WHEN adm.admission_type IN (
'ELECTIVE', 'SURGICAL SAME DAY ADMISSION'
) AND sf.surgical = 1
THEN 1
WHEN adm.admission_type IS NULL OR sf.surgical IS NULL
THEN NULL
Expand Down
8 changes: 6 additions & 2 deletions mimic-iv/concepts/score/sapsii.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,9 +326,13 @@ WITH co AS (
, comorb.mets

, CASE
WHEN adm.admission_type = 'ELECTIVE' AND sf.surgical = 1
WHEN adm.admission_type IN (
'ELECTIVE', 'SURGICAL SAME DAY ADMISSION'
) AND sf.surgical = 1
THEN 'ScheduledSurgical'
WHEN adm.admission_type != 'ELECTIVE' AND sf.surgical = 1
WHEN adm.admission_type NOT IN (
'ELECTIVE', 'SURGICAL SAME DAY ADMISSION'
) AND sf.surgical = 1
THEN 'UnscheduledSurgical'
ELSE 'Medical'
END AS admissiontype
Expand Down
4 changes: 3 additions & 1 deletion mimic-iv/concepts_duckdb/score/oasis.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ WITH surgflag AS (
vent.vent AS mechvent,
uo.urineoutput,
CASE
WHEN adm.admission_type = 'ELECTIVE' AND sf.surgical = 1
WHEN adm.admission_type IN (
'ELECTIVE', 'SURGICAL SAME DAY ADMISSION'
) AND sf.surgical = 1
THEN 1
WHEN adm.admission_type IS NULL OR sf.surgical IS NULL
THEN NULL
Expand Down
8 changes: 6 additions & 2 deletions mimic-iv/concepts_duckdb/score/sapsii.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,13 @@ WITH co AS (
comorb.hem,
comorb.mets,
CASE
WHEN adm.admission_type = 'ELECTIVE' AND sf.surgical = 1
WHEN adm.admission_type IN (
'ELECTIVE', 'SURGICAL SAME DAY ADMISSION'
) AND sf.surgical = 1
THEN 'ScheduledSurgical'
WHEN adm.admission_type <> 'ELECTIVE' AND sf.surgical = 1
WHEN adm.admission_type NOT IN (
'ELECTIVE', 'SURGICAL SAME DAY ADMISSION'
) AND sf.surgical = 1
THEN 'UnscheduledSurgical'
ELSE 'Medical'
END AS admissiontype
Expand Down
4 changes: 3 additions & 1 deletion mimic-iv/concepts_postgres/score/oasis.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ WITH surgflag AS (
vent.vent AS mechvent,
uo.urineoutput,
CASE
WHEN adm.admission_type = 'ELECTIVE' AND sf.surgical = 1
WHEN adm.admission_type IN (
'ELECTIVE', 'SURGICAL SAME DAY ADMISSION'
) AND sf.surgical = 1
THEN 1
WHEN adm.admission_type IS NULL OR sf.surgical IS NULL
THEN NULL
Expand Down
8 changes: 6 additions & 2 deletions mimic-iv/concepts_postgres/score/sapsii.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,13 @@ WITH co AS (
comorb.hem,
comorb.mets,
CASE
WHEN adm.admission_type = 'ELECTIVE' AND sf.surgical = 1
WHEN adm.admission_type IN (
'ELECTIVE', 'SURGICAL SAME DAY ADMISSION'
) AND sf.surgical = 1
THEN 'ScheduledSurgical'
WHEN adm.admission_type <> 'ELECTIVE' AND sf.surgical = 1
WHEN adm.admission_type NOT IN (
'ELECTIVE', 'SURGICAL SAME DAY ADMISSION'
) AND sf.surgical = 1
THEN 'UnscheduledSurgical'
ELSE 'Medical'
END AS admissiontype
Expand Down
Loading