Fix: use CONCAT with CAST to create interval for DATETIME_ADD - #1847
Open
flybitcone wants to merge 1 commit into
Open
Fix: use CONCAT with CAST to create interval for DATETIME_ADD#1847flybitcone wants to merge 1 commit into
flybitcone wants to merge 1 commit into
Conversation
Author
|
The check is not pass may be due to the Python version in the test environment. Pls check the error in detain: Thanks. |
Chessing234
reviewed
Jul 29, 2026
Chessing234
left a comment
Contributor
There was a problem hiding this comment.
this file is marked auto-generated — usually you want to fix the bigquery source and re-transpile rather than hand-edit concepts_postgres. also the patch drops the mimiciv_derived. schema and brings in GENERATE_ARRAY / DATETIME_ADD, which won't run as plain postgres. if the goal is interval construction, maybe keep GENERATE_SERIES + + INTERVAL '1' HOUR like the current transpiled version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the interval and CROSS JOIN function