Skip to content

Fix: Adding missing @:DEALLOCATE's#1592

Open
joshgillis wants to merge 1 commit into
MFlowCode:masterfrom
joshgillis:deallocate-branch
Open

Fix: Adding missing @:DEALLOCATE's#1592
joshgillis wants to merge 1 commit into
MFlowCode:masterfrom
joshgillis:deallocate-branch

Conversation

@joshgillis

Copy link
Copy Markdown

Description

Added the two DEALLOCATE calls for Res_gs (line 105, within viscous if statement) and Gs_rs (line 111) needed in src/simulation/m_riemann_solvers.fpp

Closes #1568.

Type of change

  • Bug fix

Testing

Ran test suite on personal machine using CPU for both --no-mpi and --mpi. Then ran test suite on Tuolumne in lustre5 storage, using ./mfc.sh test -j 16 --mpi --gpu acc -- -c tuo. All cases passed for all testing instances.

Checklist

Check these like this [x] to indicate which of the below applies.

  • I added or updated tests for new behavior
  • I updated documentation if user-facing behavior changed

See the developer guide for full coding standards.

GPU changes (expand if you modified src/simulation/)
  • GPU results match CPU results
  • Tested on NVIDIA GPU or AMD GPU

AI code reviews

Reviews are not retriggered automatically. To request a review, comment on the PR:

  • @claude full review — Claude full review (also triggers on PR open/reopen/ready)
  • Or add label claude-full-review — Claude full review via label

@joshgillis joshgillis marked this pull request as ready for review June 13, 2026 23:21
@joshgillis joshgillis requested a review from sbryngelson as a code owner June 13, 2026 23:21
@codecov

codecov Bot commented Jun 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.94%. Comparing base (ac5774e) to head (aba6cfb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1592   +/-   ##
=======================================
  Coverage   60.94%   60.94%           
=======================================
  Files          82       82           
  Lines       19922    19922           
  Branches     2924     2924           
=======================================
  Hits        12141    12141           
  Misses       5805     5805           
  Partials     1976     1976           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Gs_rs and Res_gs are @:ALLOCATE'd but never deallocated in the Riemann finalizer

1 participant