Skip to content

Apply targeted fixes to prodl-core - #3

Merged
ClausValcaTD merged 1 commit into
mainfrom
fix-prodl-core-download-options-13884154172990168607
Sep 1, 2026
Merged

Apply targeted fixes to prodl-core#3
ClausValcaTD merged 1 commit into
mainfrom
fix-prodl-core-download-options-13884154172990168607

Conversation

@ClausValcaTD

Copy link
Copy Markdown
Collaborator

Applied 4 targeted fixes to packages/prodl-core:

  1. Added progress_hook and max_filesize fields to DownloadOptions in models.py with arbitrary_types_allowed config.
  2. Removed glob usage in downloader.py and extracted output filepath using requested_downloads.
  3. Wired progress_hook and max_filesize into ydl_opts in download().
  4. Updated get_stream_info() to extract direct URL from requested_downloads with fallback to info['url'].

PR created automatically by Jules for task 13884154172990168607 started by @ClausValcaTD

- Add progress_hook and max_filesize fields to DownloadOptions
- Wire progress_hook and max_filesize into ydl_opts in downloader.py
- Extract output filepath via info['requested_downloads'][0]['filepath']
- Remove glob usage from downloader.py
- Update get_stream_info direct URL extraction with fallback

Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ClausValcaTD
ClausValcaTD merged commit d4aefa2 into main Sep 1, 2026
1 check passed
@ClausValcaTD
ClausValcaTD deleted the fix-prodl-core-download-options-13884154172990168607 branch September 1, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant