fix(sia-video-source): preserve reload pauses - #1196
Merged
Merged
Conversation
- settle an armed pause confirmation before re-stating PLAY at ATTACH_OK - a pause issued during reload updates the playback preference first - share the next-task settle path via #settlePauseConfirmIfArmed
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
pcfreak30
marked this pull request as ready for review
September 24, 2026 19:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settles an armed pause confirmation before replaying a source after ATTACH_OK.
A pause issued during reload now updates playback preference before the host decides whether to send PLAY.
Summary
Fixes an issue where a user pause triggered during a configuration reload could be lost, causing the reloaded video source to re-start playback instead of respecting the pause.
What changed
PLAYover a live user pause and then cancelling the pause confirmation as part of the load-state reset.PLAYmessage.