Skip to content

fix(sia-video-source): preserve reload pauses - #1196

Merged
pcfreak30 merged 1 commit into
developfrom
fix/sia-video-source-preserve-reload-pauses
Sep 24, 2026
Merged

pcfreak30 merged 1 commit into
developfrom
fix/sia-video-source-preserve-reload-pauses

Conversation

@pcfreak30

@pcfreak30 pcfreak30 commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Settles an armed pause confirmation before replaying a source after ATTACH_OK.

A pause issued during reload now updates playback preference before the host decides whether to send PLAY.


Summary

Fixes an issue where a user pause triggered during a configuration reload could be lost, causing the reloaded video source to re-start playback instead of respecting the pause.

What changed

  • When a reload re-attaches and replays the existing source, any provisional pause confirmation that is still pending is now settled before the playback state is re-evaluated.
  • This prevents the reload from re-stating PLAY over a live user pause and then cancelling the pause confirmation as part of the load-state reset.
  • The pause-confirmation handling was extracted into a shared helper used both by the scheduled timer and the reload path, keeping behavior consistent.
  • Added a regression test that verifies a pause issued during a reload window is preserved and the rebuilt load does not emit a PLAY message.

- settle an armed pause confirmation before re-stating PLAY at ATTACH_OK
- a pause issued during reload updates the playback preference first
- share the next-task settle path via #settlePauseConfirmIfArmed
@kody-ai

kody-ai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ✅

Access your configuration settings here.

​

@pcfreak30
pcfreak30 marked this pull request as ready for review September 24, 2026 19:33
@pcfreak30
pcfreak30 merged commit c462093 into develop Sep 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant