Repository navigation
Stay pairable after an abandoned Omnipod 5 pairing; name it pod simulator - #27
Merged
Merged
Conversation
…ator An unpaired Omnipod 5 took its controller's id from the HELLO and put it in the service UUID it advertises, as a paired one does. If the phone then abandoned the pairing, the pod no longer matched the phone's scan for an unpaired pod and could not be found again. Only a paired pod takes the id from the HELLO now; an unpaired one takes it when pairing produces the LTK. Also name a simulated Omnipod 5 "pod simulator" instead of copying the real pod's "AP <controller id> <lot><tid>". Nothing reads the name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairable after an abandoned pairing. An unpaired Omnipod 5 took its controller's id from the phone's HELLO and put it in the one service UUID it advertises, as a paired pod does. If the phone then abandoned the pairing (hung up partway through the exchange), the pod no longer matched the phone's scan for an unpaired pod (
…0AFFFFFFFE00), so Loop reported "No pods found" and the pod could not be paired without restarting the simulator.Only a paired pod takes the id from the HELLO now. An unpaired pod keeps advertising
FFFFFFFEuntil pairing produces the LTK, where it already adopts the id. A phone that hangs up mid-exchange reconnects and starts over, whichreadSetupalready handles.This comes up with loopandlearn/OmnipodKit#202, which now stops pairing before the LTK is agreed when the pod's certificate is not Insulet's, and pairs again from scratch if the user chooses to continue.
Name. A simulated Omnipod 5 advertises the name
pod simulatorinstead of copying the real pod'sAP <controller id> <lot><tid>. Nothing reads the name; Loop only shows it as the device name. A DASH keeps:: Fake POD ::.Testing.
go test ./...passes, andGOOS=linux go vet ./pkg/bluetooth/covers the Linux GATT radio. In the iOS Simulator, through ImpossiBLE, Loop with loopandlearn/OmnipodKit#202 abandoned an Omnipod 5 pairing at the certificate step, then found the pod again and started a new exchange on retry.