Skip to content

Move the settings into UIFoundation's Settings window #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mx-Iris merged 5 commits into from
Oct 11, 2026
Merged

Move the settings into UIFoundation's Settings window #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d9b105
Keep the settings' value rules in LookInsideHostCore
Mx-Iris Oct 11, 2026
4e8fac7
Show the settings in UIFoundation's Settings window
Mx-Iris Oct 11, 2026
51cf4ef
Lay out the Settings window the way RuntimeViewer does
Mx-Iris Oct 11, 2026
0b94933
Give the reset and the default library update labeled rows
Mx-Iris Oct 11, 2026
2df221c
Center the action rows' buttons on both lines
Mx-Iris Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions LookInside.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
E972100D2FC2E5C0003AAEA6 /* InjectionServiceInterface in Frameworks */ = {isa = PBXBuildFile; productRef = E972100C2FC2E5C0003AAEA6 /* InjectionServiceInterface */; };
E9FE990C3026C657008692AF /* UIFoundation in Frameworks */ = {isa = PBXBuildFile; productRef = E9FE990B3026C657008692AF /* UIFoundation */; };
E9FE990E3026C657008692AF /* UIFoundationToolbox in Frameworks */ = {isa = PBXBuildFile; productRef = E9FE990D3026C657008692AF /* UIFoundationToolbox */; };
E9FE99103026C657008692AF /* UIFoundationSettingsUI in Frameworks */ = {isa = PBXBuildFile; productRef = E9FE990F3026C657008692AF /* UIFoundationSettingsUI */; };
F0F0A10E2FD0000100A1B2C3 /* FoundationToolbox in Frameworks */ = {isa = PBXBuildFile; productRef = F0F0A10D2FD0000100A1B2C3 /* FoundationToolbox */; };
/* End PBXBuildFile section */

Expand Down Expand Up @@ -193,9 +194,6 @@
Measure/MeasureController.swift,
Measure/MeasureResultView.swift,
Other/VersionComparer.swift,
Preference/PreferenceView.swift,
Preference/PreferenceWindowController.swift,
PrivateDiscriminator/PrivateDiscriminatorSettingsWindowController.swift,
PrivateDiscriminator/PrivateDiscriminatorStore.swift,
Read/ArchiveCoding.swift,
Read/ArchiveDocument.swift,
Expand All @@ -204,6 +202,9 @@
Read/ReadScreenshotLookup.swift,
Read/ReadViewController.swift,
Read/ReadWindowController.swift,
Settings/GeneralSettingsPage.swift,
Settings/PrivateDiscriminatorSettingsPage.swift,
Settings/SettingsPages.swift,
Static/MessageManager.swift,
Static/Preview/DisplayItemNode.swift,
Static/Preview/PreviewController.swift,
Expand Down Expand Up @@ -299,6 +300,7 @@
E972100B2FC2E5C0003AAEA6 /* HelperCommunication in Frameworks */,
E972100D2FC2E5C0003AAEA6 /* InjectionServiceInterface in Frameworks */,
E9FE990E3026C657008692AF /* UIFoundationToolbox in Frameworks */,
E9FE99103026C657008692AF /* UIFoundationSettingsUI in Frameworks */,
F0F0A10E2FD0000100A1B2C3 /* FoundationToolbox in Frameworks */,
15FFB4D96CB7375162952FFE /* LookInsideActivation in Frameworks */,
79CC3F736CA547232F1827F4 /* LookInsideActivationUI in Frameworks */,
Expand Down Expand Up @@ -366,6 +368,7 @@
E972100C2FC2E5C0003AAEA6 /* InjectionServiceInterface */,
E9FE990B3026C657008692AF /* UIFoundation */,
E9FE990D3026C657008692AF /* UIFoundationToolbox */,
E9FE990F3026C657008692AF /* UIFoundationSettingsUI */,
F0F0A10D2FD0000100A1B2C3 /* FoundationToolbox */,
4CF60A9D44E04A6BE91035EF /* LookInsideActivation */,
F05DCA7C93CF923C02603F72 /* LookInsideActivationUI */,
Expand Down Expand Up @@ -884,6 +887,7 @@
};
traits = (
AppleInternal,
Settings,
);
};
F0F0A10A2FD0000100A1B2C3 /* XCRemoteSwiftPackageReference "FrameworkToolbox" */ = {
Expand Down Expand Up @@ -952,6 +956,11 @@
package = E9FE990A3026C657008692AF /* XCRemoteSwiftPackageReference "UIFoundation" */;
productName = UIFoundationToolbox;
};
E9FE990F3026C657008692AF /* UIFoundationSettingsUI */ = {
isa = XCSwiftPackageProductDependency;
package = E9FE990A3026C657008692AF /* XCRemoteSwiftPackageReference "UIFoundation" */;
productName = UIFoundationSettingsUI;
};
F05DCA7C93CF923C02603F72 /* LookInsideActivationUI */ = {
isa = XCSwiftPackageProductDependency;
package = E81BCA16A46AEA38803B27B7 /* XCLocalSwiftPackageReference "Packages/LookInsideActivation" */;
Expand Down
11 changes: 5 additions & 6 deletions LookInside/DebugE2E/DebugUISnapshots.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,10 +217,10 @@
try await readRoundTrip(exported)

// Windows of their own.
NavigationManager.shared.showPreference()
try await captureStandaloneWindow("preferences", controllerKey: "preferenceWindowController")
NavigationManager.shared.showSettings()
try await captureStandaloneWindow("settings") { NavigationManager.shared.settingsWindowController }
NavigationManager.shared.showAbout()
try await captureStandaloneWindow("about", controllerKey: "aboutWindowController")
try await captureStandaloneWindow("about") { NavigationManager.shared.aboutWindowController }
try await captureActivationWindow()
}

Expand Down Expand Up @@ -276,10 +276,9 @@
window.close()
}

private func captureStandaloneWindow(_ name: String, controllerKey: String) async throws {
let navigation = NavigationManager.shared
private func captureStandaloneWindow(_ name: String, controller: () -> NSWindowController?) async throws {
let window = try await waitFor("the \(name) window") {
(navigation.value(forKey: controllerKey) as? NSWindowController)?.window.flatMap { $0.isVisible ? $0 : nil }
controller()?.window.flatMap { $0.isVisible ? $0 : nil }
}
quietWindows()
window.center()
Expand Down
Loading
Loading