PR67 F2/F3 — Preserve receiver-call authority - #69
Conversation
Close PR #67 F2/F3: a direct allowed member call on a proven SERVER/REQUEST/RESPONSE target, or a call of a permitted static member of a proven global root, now yields a result that conservatively retains the receiver's authority through the existing fact model and policies. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q6Mog1KsMYfH2GAVMw9mbg
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 631ef66a39
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (isProvenCreateServerCall(ctx, node) || isConfinedFactoryCall(ctx, node)) return [{ authority: 'SERVER', origin: 'ROOT' }]; | ||
| if (ts.isIdentifier(node)) return factsOf(ctx, valueSymbolOf(ctx.checker, node)); | ||
| const receiver = inheritingReceiverOf(ctx, node); | ||
| return receiver === null ? [] : expressionFacts(ctx, receiver); |
There was a problem hiding this comment.
For a chain of allowed receiver calls such as server.close().close()..., inheritingReceiverOf already evaluates the receiver via classesOf, but this line immediately evaluates the same receiver again. Each nesting level therefore doubles the work (T(n) = 2T(n-1)); a valid chain of only 20 calls can keep the policy analyzer CPU-bound for tens of seconds, bypassing the intended bounded analysis behavior and potentially stalling CI. Cache the expression facts or have the helper return the facts it already computed.
Useful? React with 👍 / 👎.
1 participant
Purpose
Stacked validation repair for PR #67 exact parent HEAD:
6f4c9cc5011de7156f8b0c1c391af5425e1a4e44This child repairs two exact-head CURRENT P1 findings from the PR #67 Codex review:
Bounded mechanism
One structural correction:
receiver-call result authority inheritance.
For proven SERVER / REQUEST / RESPONSE targets, an allowed direct non-optional member-call result conservatively retains the receiver's existing authority facts.
For the global-root path, a permitted static member-call result is conservatively re-checked as a global root for both normal and optional calls.
No runtime method-return semantics are inferred by name.
Scope
Changed files exactly:
tests/cockpit-host/support/d3-network-policy.tstests/cockpit-host/support/d3-regression-matrix.tstests/cockpit-host/d3-network-policy.test.tsNo production source changes.
Preserved architecture
No EventSource change.
No
valueOf-specific implementation rule.No dangerous-member-name model.
No PR #64 mechanism restoration.
No type-resolution, prototype-chain, or whole-program expansion.
Validation
Exact validated repair commit:
631ef66a391eced86055982766c2bd29a0061e84Parent:
6f4c9cc5011de7156f8b0c1c391af5425e1a4e44Validated binary patch:
3DE8BC66E0427F0CFCF987BA0CFFF0CD8E40653D63CD4B095DB2F94F4985B71336648 bytesFresh independent validation verdict:
VALIDATOR_PASS_PR67_F2_F3_CANDIDATEDeterministic validation:
Independent adversarial validation found no CURRENT P0/P1/P2 second-order defect in the repaired mechanism.
A separate confined-factory optional-call discriminator was classified NOT REPRODUCIBLE because the pre-existing
SERVER_UNCONFINED_RETURNmechanism already denies the source.Authority
This is a DRAFT stacked validation PR.
Ready, reviewer trigger, and merge authority are NOT granted by creation.
PR #67 remains Draft and untouched.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Q6Mog1KsMYfH2GAVMw9mbg