Skip to content

implement grpc request scope#198

Open
bherrmann2 wants to merge 1 commit into
LogNet:masterfrom
bherrmann2:grpc-request-scope
Open

implement grpc request scope#198
bherrmann2 wants to merge 1 commit into
LogNet:masterfrom
bherrmann2:grpc-request-scope

Conversation

@bherrmann2

@bherrmann2 bherrmann2 commented Apr 5, 2021

Copy link
Copy Markdown

This is to port over the grpc request scope added in https://github.com/yidongnan/grpc-spring-boot-starter in the following PR https://github.com/yidongnan/grpc-spring-boot-starter/pull/259 (by @ST-DDT)

@Bean
@Scope(scopeName = GRpcRequestScope.GRPC_REQUEST_SCOPE_NAME, proxyMode = ScopedProxyMode.TARGET_CLASS)
BeanType beanName() {
        return new BeanType();
}

@bherrmann2 bherrmann2 force-pushed the grpc-request-scope branch from 5fa83b7 to 2d0be5f Compare April 5, 2021 21:49
@bherrmann2

Copy link
Copy Markdown
Author

@jvmlet can you take a look at this?

@jvmlet

jvmlet commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

Did you ask the author of this feature if he is OK with copying the implementation as is?

@bherrmann2

Copy link
Copy Markdown
Author

The copyright notice in the code gives explicit permission to copy it, but I can attempt to reach out

@bherrmann2

Copy link
Copy Markdown
Author

I have reached out here: #177 (comment)

@ST-DDT

ST-DDT commented Apr 11, 2021

Copy link
Copy Markdown

I consent to my code being ported over.

@ST-DDT ST-DDT left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (I haven't tested it though).

@bherrmann2

Copy link
Copy Markdown
Author

I have now tagged you in the PR description @ST-DDT . I wasn't able to before you approved/commented on the PR since you weren't a contributor on this project.

@ST-DDT

ST-DDT commented Apr 11, 2021

Copy link
Copy Markdown

FFR: It is possible even without that, but auto completion does not work.

@bherrmann2

Copy link
Copy Markdown
Author

@jvmlet I got the permission and approval. Let me know if this is ok

@bherrmann2

Copy link
Copy Markdown
Author

@jvmlet can you take another look?

@bherrmann2

Copy link
Copy Markdown
Author

@jvmlet Can you please review this? I would still like to get this in

@deft1991

Copy link
Copy Markdown

Can you please merge it?

@bherrmann2

Copy link
Copy Markdown
Author

@deft1991 . We need @jvmlet to reivew, approve, and merge.

@hehe717

hehe717 commented Aug 25, 2021

Copy link
Copy Markdown

@jvmlet is there any update?
I want to use this feature.

@hehe717 hehe717 mentioned this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants