Skip to content

fix(linux): run notify and acknowledge in async#141

Draft
Kishi85 wants to merge 1 commit into
LizardByte:masterfrom
Kishi85:run-notify-async-in-eventloop
Draft

fix(linux): run notify and acknowledge in async#141
Kishi85 wants to merge 1 commit into
LizardByte:masterfrom
Kishi85:run-notify-async-in-eventloop

Conversation

@Kishi85
Copy link
Copy Markdown

@Kishi85 Kishi85 commented May 31, 2026

Description

This is a new try (this time using libnotifys main event loop) to run tray notify and acknowledge async to avoid blocked DBus function calls to cause issues in implementors of this library.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@Kishi85 Kishi85 force-pushed the run-notify-async-in-eventloop branch from 860badc to 6d368cf Compare May 31, 2026 16:38
@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2026

Codecov Report

❌ Patch coverage is 74.54545% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.74%. Comparing base (df9af11) to head (67d4cdb).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/tray_linux.cpp 74.54% 4 Missing and 10 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   63.44%   63.74%   +0.30%     
==========================================
  Files           5        5              
  Lines         621      651      +30     
  Branches      200      214      +14     
==========================================
+ Hits          394      415      +21     
- Misses        152      157       +5     
- Partials       75       79       +4     
Flag Coverage Δ
Linux-qt5 54.25% <74.54%> (+1.36%) ⬆️
Linux-qt6 54.25% <74.54%> (+1.36%) ⬆️
Windows 70.67% <ø> (ø)
macOS 56.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/tray_linux.cpp 62.50% <74.54%> (+1.84%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df9af11...67d4cdb. Read the comment docs.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 31, 2026

Last Updated 2026-05-31 20:05:05 UTC
Source Run CI Run #634
Commit 67d4cdb5fde3786fdd7e2ae17c4120d610fa8b05

Screenshot Comparison

PR #141 screenshots vs screenshots baseline.

Matrix: Linux-qt5

Image Baseline PR
tray_icon_initial.png
tray_icon_svg.png
tray_icon_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_left_click.png
tray_menu_shown.png
tray_notification_displayed.png
tray_notification_themed_icon.png

Matrix: Linux-qt6

Image Baseline PR
tray_icon_initial.png
tray_icon_svg.png
tray_icon_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_left_click.png
tray_menu_shown.png
tray_notification_displayed.png
tray_notification_themed_icon.png

Matrix: Windows

Image Baseline PR
tray_icon_initial.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_shown.png
tray_notification_displayed.png

Matrix: macOS

Image Baseline PR
tray_icon_initial.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_shown.png
tray_notification_displayed.png

@Kishi85
Copy link
Copy Markdown
Author

Kishi85 commented May 31, 2026

Screenshots look pretty broken with this unfortunately. This might take a while to figure out properly.

@ReenigneArcher
Copy link
Copy Markdown
Member

Screenshots look pretty broken with this unfortunately. This might take a while to figure out properly.

I think it's just not cleaning up between each test.

@Kishi85 Kishi85 force-pushed the run-notify-async-in-eventloop branch from 6d368cf to 67d4cdb Compare May 31, 2026 19:25
@Kishi85 Kishi85 changed the title fix(linux): run notify and acknowledge in async in event loop fix(linux): run notify and acknowledge in async May 31, 2026
@sonarqubecloud
Copy link
Copy Markdown

@Kishi85
Copy link
Copy Markdown
Author

Kishi85 commented May 31, 2026

I've changed this back to my first attempt at this (reverted in #135) with some additional changes to thread synchronization that, upon first tests, seem to fix the hang issues sunshine had with the first iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants