Conversation
|
ReenigneArcher
left a comment
There was a problem hiding this comment.
Requesting changes for the linked keyboard fix at the current heads (Sunshine f5f93a1, libvirtualhid 0271b64, Moonlight 3bace8b).
The new KeyboardEvent::stream_flags is never populated by keyboard_event() here. Sunshine only translates SS_KBE_FLAG_NON_NORMALIZED into uses_normalized_key_code; libvirtualhid #101 checks stream_flags & 0x02/0x04 to distinguish Korean Hangul/Hanja, so those branches are unreachable through Sunshine. The required Moonlight PR #1984 also still maps SDL_SCANCODE_LANG1/LANG2 to Japanese Henkan/Muhenkan key codes and does not emit these extra flag bits. Please coordinate the protocol/client mapping, pass the flags into the libvirtualhid event after its API update, and cover the packet-to-backend path. The current pair of PRs does not fix those keys.
Sunshine #5542 itself is currently mergeable, but this integration needs to be resolved before accepting the linked keyboard fix.



Description
Fix Japanese keyboard mapping
To be fixed, Need to merge all these PRs
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.