fix(linux/kwin): retry init with fully dropped elevated privileges in case KWin is missing CAP_SYS_NICE on linux#5212
Merged
ReenigneArcher merged 1 commit intoMay 29, 2026
Conversation
2418305 to
0fcb425
Compare
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5212 +/- ##
=========================================
Coverage ? 17.82%
=========================================
Files ? 111
Lines ? 24173
Branches ? 10695
=========================================
Hits ? 4310
Misses ? 15489
Partials ? 4374
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
0fcb425 to
e6f7abd
Compare
|
… case kwin is missing CAP_SYS_NICE
e6f7abd to
b50fba6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Archlinux/CachyOS packaged
kwin-6.6.5-3is not assigningCAP_SYS_NICEto KWin therefore breakingkwingrabwhich was allowed to retain the capability to improve streaming performance as part of #5075. Although this is likely a bug on the packaging end it should be properly handled in Sunshine.This PR adds handling for KWin missing CAP_SYS_NICE by checking if init succeeded in binding the screencast extension. Should that not be the case it's logging a warning, dropping ALL elevated capabilities and doing a full reinit of the screencast instance on the display object before continuing with starting the stream.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage