feat(web-ui): Updated Add / Edit app form to use modals + new Delete App UI flow#5166
Merged
Conversation
|
- Wrapped new app button to stick to the left side of the toolbar
…omodate for shrinking window
- Moved the `Add New` button to the top action bar now (doesn't make sense to keep it at the bottom - Moved the `Cover Finder Modal` from being nested in the edit form - Added `OpenEditModal`, `CloseEditModal` functions to control opening / closing of the modal - Created `ShowStacked()` to allow for modals to be stacked on one-another - Currently, only 1 modal will be stacked max, so it's safe to just keep it as a single stack - Moved some of the modals around so they're not nested within one another and can be created indipendently
- Remove duplicate set of index to `-1` - Fixed key in for loop not just being the literal string 'i' - Fixed indenting on the modal
…ser `confirm()` dialogue - Created Delete confirmation modal - Renamed `showDeleteForm` to `showDeleteModal`
- Implemented `loadApps()` to wrap the api calling the load apps endpoint - Use this endpoint when editing / addding / deleting an app (instead of hard refresh) - Added `encodeURIComponent(app['image-path'])"` onto the end of the covers API fetch to invalidate the cache (and fix a bug with covers sticking around...)
…n name that's being entered - Cretaed `editModalTitle` function to track the typing of `editForm`'s name property - Removed trailing spaces as well
…leted application's name - Switched the translation delete message to the `Component` version, so we can style the `name` - Added a bottom border to the header, and the background colour
- Removed modal header border - Bumped down the toolbar group to 14rem - Removed cache busting in favor of hard refresh - Merged magnifying glass / clear text `X` icon for search on the right side
21 tasks
Member
This can happen if too many pushes happen too fast. If you can force push it'll probably resolve itself. |
…ose` translation
|
Bundle ReportChanges will increase total bundle size by 962 bytes (0.04%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sunshine-esmAssets Changed:
Files in
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5166 +/- ##
==========================================
- Coverage 17.81% 17.80% -0.01%
==========================================
Files 111 111
Lines 24173 24173
Branches 10695 10695
==========================================
- Hits 4307 4305 -2
+ Misses 17248 15599 -1649
- Partials 2618 4269 +1651
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Newapps button to the new apps toolbar (left side of the screen)Add/Editapps form from the bottom of the screen to a new full-screen modalAdd/EditmodalDelete appmodal now instead of browser confirm popupdelete_titleanddelete_confirmto theen.jsontranslation fileAdd/Edit/DeleteUI flows to not hard force refresh (now just re-populates via calling theappsendpoint)Screenshots
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage