feat: localized names, covers, and buckets - #340
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #340 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 1034 1054 +20
=========================================
+ Hits 1034 1054 +20
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
Would it be possible to add a "global" bucket? Eg. if I don't know in which language is the title I have. |
|
Maybe, but there's probably not logic in the igdb API to set the default two character code for each one. |
|
Not everyone is still better than no one. If you'd put them along with the existing ASCII buckets like this: One could lookup any title it might have: And they would point to the same game id in the API, that's what I meant. The only down side is that I think A LOT of buckets/files would be generated for every 2-char combination existing. So maybe having the first char being a folder could help? And you could keep 1-char buckets as they are (and maybe 2 char ascii buckets for backwards-compatibility?) |
And any localized title could overwrite another. This will require knowing the language code, just as with any other API with localized strings. |



Description
Adds localized names, covers, and buckets for games.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.