Skip to content

feat: localized names, covers, and buckets - #340

Merged
ReenigneArcher merged 1 commit into
masterfrom
feat/localization
Sep 26, 2026
Merged

ReenigneArcher merged 1 commit into
masterfrom
feat/localization

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

Description

Adds localized names, covers, and buckets for games.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (af9db9e) to head (7f1f34a).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #340   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines         1034      1054   +20     
=========================================
+ Hits          1034      1054   +20     
Files with missing lines Coverage Δ
src/update_db.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9db9e...7f1f34a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Xriuk

Xriuk commented Sep 26, 2026 •

Copy link
Copy Markdown

Would it be possible to add a "global" bucket? Eg. if I don't know in which language is the title I have.
Maybe adding the localized buckets along all the existing ones instead of under a region would solve the issue. This way I would always search for the 2 initial chars.

@ReenigneArcher

Copy link
Copy Markdown
Member Author

Maybe, but there's probably not logic in the igdb API to set the default two character code for each one.

@Xriuk

Xriuk commented Sep 26, 2026 •

Copy link
Copy Markdown

Not everyone is still better than no one.
In this PR you are already populating localized buckets here:

buckets/localized/jp/ゼル.json

If you'd put them along with the existing ASCII buckets like this:

buckets/jp/ゼル.json

One could lookup any title it might have:

The Legend -> th -> buckets/th.json
ゼルダの伝説 -> ゼル -> buckets/ゼル.json

And they would point to the same game id in the API, that's what I meant.
And if localizations are not present for every game it doesn't matter.

The only down side is that I think A LOT of buckets/files would be generated for every 2-char combination existing.

So maybe having the first char being a folder could help?

buckets/t/h.json
buckets/ゼ/ル.json

And you could keep 1-char buckets as they are (and maybe 2 char ascii buckets for backwards-compatibility?)

@ReenigneArcher

Copy link
Copy Markdown
Member Author

The only down side is that I think A LOT of buckets/files would be generated for every 2-char combination existing.

And any localized title could overwrite another. This will require knowing the language code, just as with any other API with localized strings.

@ReenigneArcher
ReenigneArcher merged commit ed70c82 into master Sep 26, 2026
17 checks passed
@ReenigneArcher
ReenigneArcher deleted the feat/localization branch September 26, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants