Add WoT GameID links#7674
Open
Kanopedia wants to merge 7 commits into
Open
Conversation
hjpalpha
reviewed
Jun 17, 2026
hjpalpha
left a comment
hjpalpha
left a comment
Collaborator
There was a problem hiding this comment.
do the css classes exist?
if not they need to be created too
hjpalpha
reviewed
Jun 17, 2026
mbergen
reviewed
Jun 17, 2026
Co-authored-by: SyntacticSalt <mail@mbergen.de>
Collaborator
Author
I've updated the CSS now; but technically wotid na/eu/cn/asia all use the same icon, wotidru uses Mir Tankovs' version, any idea to better do that in CSS or just do it as I currently did? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On request by World of Tanks wiki, adding links to their profile sites that are bound to the game ID.
One thing we're running into; is that the ID's are sorted per server / have seperate domains, and then there's the 2 releases/games that are in china/russia (currently grouped it all together, but alphabetically that might need to be moved).
Still need to make the icons. will get to those later.
Could there also potentially be some other logic for the NA/EU/Asia servers to not need separate inputs?
( was atleast told the following
if the ID starts with 1 - it is NA server
if the ID starts with 2 or 3, it is APAC
if the ID starts with 5,6,7 it is EU
)
But that might also cause issues; apparently some people would have accounts across servers, so assumed this might be the simplest solution.
How did you test this change?