fixing VRSStandingSettings filterType when fetching data.#7673
Open
MischiefCS wants to merge 4 commits into
Open
fixing VRSStandingSettings filterType when fetching data.#7673MischiefCS wants to merge 4 commits into
MischiefCS wants to merge 4 commits into
Conversation
ensuring filterType is actually read, instead of inferred by specified filter
mbergen
reviewed
Jun 17, 2026
mbergen
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensuring filterType is actually read, instead of inferred by specified filter
Summary
For all current wiki applications, only one filterType is ever supplied, so previously filterType has been inferred from what the call contains.
For usage of https://liquipedia.net/counterstrike/index.php?title=Form:VRSStandings, its not possible to supply only one filter type when running multiple queries, so its not possible to accurately infer filterType. This PR is to ensure filterType is read and used
How did you test this change?
https://liquipedia.net/counterstrike/Module:VRSStandingsData/dev/MischiefCS
https://liquipedia.net/counterstrike/User:MischiefCS/FetchTest3
tested supplying multipler filters, but specifying filterType