fix(infobox): Adding a parameter to remove the unintentional <li> tag usage.#7666
Open
LemurVladimir wants to merge 1 commit into
Open
fix(infobox): Adding a parameter to remove the unintentional <li> tag usage.#7666LemurVladimir wants to merge 1 commit into
LemurVladimir wants to merge 1 commit into
Conversation
…list This should tell the "Hero entry" template not to use the hardcoded <li> tag in the inclusions.
hjpalpha
approved these changes
Jun 16, 2026
LemurVladimir
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This should tell the "Hero entry" template not to use the hardcoded
<li>tag in the inclusions.As of this PR creation, the "Hero entry" template uses the
<li>tag as intended (1st pic). Alas, it being hardcoded created the problem where all inclusions had the<li>dot attached to it, including the "Infobox cosmetic" where it wasn't needed (2nd pic).I've appended the template code so it would only add the tag if the second unnamed parameter is empty.
This PR change will add the dummy 'x' string to the function that calls for the template as that second parameter.
How did you test this change?
This change was successfully implemented on /dota2gameru.
https://liquipedia.net/dota2gameru/Модуль:Infobox/Cosmetic/Custom
https://liquipedia.net/dota2gameru/Шаблон:Hero_entry