fix(TeamCard/Legacy): Changed behaviour in input processing#7658
Open
hjpalpha wants to merge 4 commits into
Open
fix(TeamCard/Legacy): Changed behaviour in input processing#7658hjpalpha wants to merge 4 commits into
hjpalpha wants to merge 4 commits into
Conversation
hjpalpha
force-pushed
the
tc-legacy-edge-case
branch
2 times, most recently
from
991e1b9 to
d8f401c
Compare
hjpalpha
force-pushed
the
tc-legacy-edge-case
branch
from
38c2694 to
3b3f788
Compare
mbergen
reviewed
Jun 14, 2026
| link = tcArgs[prefix .. 'link'], | ||
| flag = tcArgs[prefix .. 'flag_o'] or tcArgs[prefix .. 'flag'], | ||
| link = pageName, | ||
| flag = tcArgs[prefix .. 'flag_o'] or tcArgs[prefix .. 'flag'] or getNationality(pageName), |
Collaborator
There was a problem hiding this comment.
This won't be sufficient in case one of them has no page, right?
We'd actually need to disable using vars in that case.
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| flag = tcArgs[prefix .. 'flag_o'] or tcArgs[prefix .. 'flag'] or getNationality(pageName), | |
| flag = tcArgs[prefix .. 'flag_o'] or tcArgs[prefix .. 'flag'] or getNationality(pageName) or 'unknown', |
maybe like this?
else i would have to check on it when on pc again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TC Legacy wrapper changed the behaviour for how player data is processed in comparison to the old TC.
This can lead to unexpected and faulty behaviour in edge cases.
Namely if there are 2 players with different links but the same display name.
In this case reading from wiki vars as TP does can cause issues.
Hence restore the old behaviour that TC had via some adjusts in the legacy wrapper so that:
fwiw i hate this solution but i couldn't think of a different one...
only alternative i see would be to build a query to find all affected pages across all wikis and fix them manually ... (too much work imo ...)
open question
do we need it for staff etc too?
How did you test this change?
|dev=hjpon https://liquipedia.net/valorant/index.php?title=VCT/2025/Game_Changers_Championship&oldid=1262980(needs to be the old revision as a temp solution has been applied to that specific page for now)