perf: constant-time match lookups in standings model#7650
Open
Rathoz wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Rathoz
force-pushed
the
standings-fetch-lookups
branch
from
4b857f4 to
c52fc6f
Compare
hjpalpha
approved these changes
Jun 12, 2026
ElectricalBoy
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standings.fetchMatches: replaced the per-match linearTable.includesscan overmatchidswith a set (wantedMatchIdstable built viaTable.map), so each match lookup is O(1) instead of O(n). Result ordering (bracket order) is unchanged.Standings.fetchMatch: replacedMatchGroupUtil.fetchMatches(bracketId)+ filter-all-then-pick-one with a directMatchGroupUtil.fetchMatchGroup(bracketId).matchesById[matchid]lookup.fetchMatchGroupis already memoized, so this avoids re-filtering all bracket matches on every call. Existing nil-safety early returns are preserved.Based on standings-tests-ai (#7647).
How did you test this change?
busted --run=ci: 605 successes / 0 failures / 0 errors / 0 pendingluacheck lua/wikis/commons/Standings.lua: 0 warnings / 0 errors🤖 Generated with Claude Code