feat(Infobox): add Fortnite Power Rankings for players and organizations#7633
feat(Infobox): add Fortnite Power Rankings for players and organizations#7633Mehdi9120310391 wants to merge 28 commits into
Conversation
|
Note from hesketh2: I've mentioned this internally to our Community Team + Nydra and it's good to go from our end, the more cooler features specially community-driven the better : ) |
| ---@param team string | ||
| ---@return string? score | ||
| ---@return string? rank | ||
| local function fetchPowerRanking(team) |
There was a problem hiding this comment.
What's the reason org rankings are stored in LPDB, but player rankings are stored in a plain module?
Ideally we use the same here to reduce complexity.
There was a problem hiding this comment.
It can be difficult to understand, so I'll explain.
On Fortnite, organizations are not officially recognized on the professional "FNCS" circuit; only players are. These players earn Power Ranking (PR) points through their various tournament performances. This PR is managed by Epic Games' official API, whose data is public. My hosted bot is responsible for retrieving this data and pushing it to Liquipedia via the "Module:PowerRankings/Data" page. It only contains player data.
The logic behind needing to use LPDB is specifically for organizations, with the goal of adding them to a ranking to determine which one is in the best position compared to the others over a given period. That's why the two differ so much.
Do you see what I mean?
There was a problem hiding this comment.
I get that there are currently different sources, what i'm trying to hint you towards is to consider whether it makes sense to also push the player data into LPDB. This would allow, for example but not limited to, future use of historical data, e.g. charts.
It's not necessary to do so, but it is a nice thing to have.
There was a problem hiding this comment.
I would like to, but could you help me doing that? wanna make sure I won't break anything 😅
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
infoboxes (especially infobox player) are already pretty long, does it have to be displayed in the infobox?
have you considered displaying it somewhere else on the page?
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
not really, for me it's the best option |
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
review for Module:PowerRankings
(don't have the time to review the other one atm, will likely review it in the next days)
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
skimmed through it on phone
Applying hjpalpha's code
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
to make the limter happy (line length)
There was a problem hiding this comment.
note to self (for friday/saturday):
- add storage
- add function the infoboxes can call, that fetches from storage and builds the display of the rank (not of the name field)
5 participants
Summary
We have implemented a "power ranking" system for the various organizations present on Fortnite, based on data such as the PR of the organization's players (using official data provided by Epic Games) who are in the top 200 best players in the world, as well as the organization's earnings for the year in question.
Rankings:
How did you test this change?
|dev=mej: