Skip to content

feat(TeamCard): add mobilelegends Legacy wrapper Custom#7624

Draft
Eetwalt wants to merge 2 commits into
mainfrom
tc-lw-mlbb
Draft

feat(TeamCard): add mobilelegends Legacy wrapper Custom#7624
Eetwalt wants to merge 2 commits into
mainfrom
tc-lw-mlbb

Conversation

@Eetwalt

@Eetwalt Eetwalt commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

⚠️ Drafting until ENC qualifier tournaments have been converted to using TP by @Hesketh2

  • Add Module:TeamCard/Legacy/Custom for mobilelegends, part of the TC → TeamParticipants migration.
  • preprocessCard applies slot-index role defaulting for the main roster (p1p5: exp/jungler/mid/gold/roamer from InGameRoles sortOrder) so cards without explicit pNpos keep their auto role icons.
  • Maps the tNposM staff-tab position form to tNpMpos for the t2/t3 tabs.

How did you test this change?

dev

Copilot AI review requested due to automatic review settings June 8, 2026 10:11
@Eetwalt Eetwalt requested review from a team as code owners June 8, 2026 10:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Mobile Legends–specific Module:TeamCard/Legacy/Custom wrapper to support the Legacy TeamCard → TeamParticipants migration by normalizing position args and applying per-slot role defaults for the main roster.

Changes:

  • Introduces lua/wikis/mobilelegends/TeamCard/Legacy/Custom.lua wrapper delegating to Module:TeamCard/Legacy.
  • Adds preprocessCard hook to (a) alias posNpNpos and (b) default p1posp5pos via InGameRoles.sortOrder.
  • Normalizes t2posN/t3posN into t2pNpos/t3pNpos for tab players.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lua/wikis/mobilelegends/TeamCard/Legacy/Custom.lua
@Rathoz

Rathoz commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Can we do the same thing with MLBB as we did with HOK?

@Eetwalt

Eetwalt commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

Can we do the same thing with MLBB as we did with HOK?

as in convert ENC pages to TP before roll out?

@Rathoz

Rathoz commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Can we do the same thing with MLBB as we did with HOK?

as in convert ENC pages to TP before roll out?

ENC "qualifier" (tournaments giving ENC points), yeah

(without using import=true on those, in order to preserve the order of playerS)

@Eetwalt

Eetwalt commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

Can we do the same thing with MLBB as we did with HOK?

as in convert ENC pages to TP before roll out?

ENC "qualifier" (tournaments giving ENC points), yeah

(without using import=true on those, in order to preserve the order of playerS)

Yes that was the plan, I'll ask for some help for this

@Eetwalt Eetwalt marked this pull request as draft June 9, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants