Repository navigation
i18n: offer Chinese by script (zh-Hans/zh-Hant) and extract the window shell - #77
Merged
Merged
Conversation
|
Someone is attempting to deploy a commit to the sivadaboi's projects Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Thanks, splitting Chinese by script is a good call, and approved. Two requests:
|
Janlhin
pushed a commit
to Janlhin/OpenSave
that referenced
this pull request
Oct 18, 2026
A saved 'zh-CN' (or any other zh-* tag) from before the script split is no longer a LOCALES id, so it fell back to the system language and someone who picked Chinese silently lost it. sanitizeLocale now maps such tags through scriptFor: zh-CN -> zh-Hans, zh-TW/zh-HK/zh-MO -> zh-Hant, bare zh -> zh-Hans. Non-Chinese garbage still rejects to null. Requested by Omar-VF in Liquid-co#77.
Author
|
Done: Heads-up for the key migrations in #55 / #84 and the draft stack: we renamed Holding the rebase until you confirm #54 / #84 have landed, as you suggested — will rebase once and push here. |
Collaborator
added 5 commits
October 19, 2026 18:13
Whether a reader wants simplified or traditional characters is not the same question as where they are, so Chinese is no longer split into zh-CN / zh-TW / zh-HK and the rest. Two scripts are offered instead, and each region maps onto one of them. - zh-CN.json becomes zh-Hans.json. - zh-Hant.json is new: all 167 keys, converted with OpenCC (s2twp). Two words that OpenCC renders the wrong way round are corrected by hand: 镜像 (not 映象) and 帳號 (not 賬號). - scriptFor() reads the script out of an OS language tag: zh-TW, zh-HK, zh-MO and any zh-Hant-* are traditional; every other Chinese region, and a bare zh, are simplified. A tag naming its own script wins over the region guess. - The catalog tests walk a list of catalogs, so a new language is one line there plus one in LOCALES. npm test: 310/310.
…sts)
Whatever page you are on, these are on screen: the minimise / maximise /
close buttons, the status line, the transfers panel and the toast's
dismiss button, plus the shared Close / Dismiss / Loading labels the
dialogs and the skeleton use.
- Two keys are plurals (statusBar.syncing, statusBar.devicesOnline).
Chinese has a single form, so both Chinese catalogs carry a plain
string with {n}.
- transfers.readError fills {error}; the status bar's hand-built
"1 game / 2 games" plural is replaced by the catalog's own.
- 21 new keys in each catalog.
Left for another PR, because they are not plain strings:
- the paused status and PauseButton: their text embeds pauseLength()
- CloudOfferBanner and PairingBanner: the sentence is assembled around
a device name in English word order
- Sidebar's "in progress", CommandPalette's entries, ConflictModal and
LocationConflictModal
npm test: 310/310.
Review pass on the ported keys: - unify save-folder term (存档文件夹 / 存檔資料夾) in noSavesYet - unify program term (游戏程序 / 遊戲程式) with chooseProgram/programDialog - align noSavesHere / noSavesYet phrasing (没有找到它的存档) - theGame: 该游戏 -> 这款游戏 (more natural inline) - already: 请改为将该条目关联到 -> 请把该条目关联到 - rename home.trackGameTitle -> home.trackGameHint (it is the button's hint text, not a title; the dialog title is home.findGame.title)
A saved 'zh-CN' (or any other zh-* tag) from before the script split is no longer a LOCALES id, so it fell back to the system language and someone who picked Chinese silently lost it. sanitizeLocale now maps such tags through scriptFor: zh-CN -> zh-Hans, zh-TW/zh-HK/zh-MO -> zh-Hant, bare zh -> zh-Hans. Non-Chinese garbage still rejects to null. Requested by Omar-VF in Liquid-co#77.
zh-CN is no longer a LOCALES id after the script split; the test must target zh-Hans, the Simplified catalog, to assert Chinese text.
Janlhin
force-pushed
the
pr-1-window-shell
branch
from
October 19, 2026 10:22
725d2a5 to
9adcd80
Compare
Merged
Omar-VF
added a commit
that referenced
this pull request
Oct 20, 2026
ChakraFusion
pushed a commit
to ChakraFusion/OpenSave
that referenced
this pull request
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements step 1 of the i18n plan from #18: Chinese offered by script instead of region, and the window shell extracted into the catalog.
What
lib/i18n.jsgainsscriptFor():tw/hk/moresolve to Traditional, everything else to Simplified. The Settings picker lists 中文（简体） and 中文（繁體） as separate entries; an explicit pick is persisted, "System default" resolves throughscriptFor(), and<html lang>follows (zh-Hans/zh-Hant).TitleBar,StatusBar(incl. the syncing / devices-online plurals throughIntl.PluralRules— Chinese uses the single form),TransfersPanel,Toasts, plus theModal/Skeletonprimitives that render user-facing text. One sentence per key; keys grouped per component (titleBar.*,statusBar.*,transfers.*,common.*).home.trackGame*,home.findGame.*,home.addGame.recognisedAs) are ported into both scripts. A review pass applied on top: save-folder and program terms unified (存档文件夾 / 游戏程序), the noSavesHere / noSavesYet phrasings aligned, inline 该游戏 → 这款游戏, and one sentence smoothed. zh-Hant is the OpenCC s2twp rendering with the catalog's current house terms (跟踪/資料庫/程式/資料夾; the 追蹤/搜尋 polish pass comes as a later PR in this series).home.trackGameTitle→home.trackGameHint— it is the button's hint text, not a title (the dialog title ishome.findGame.title). Worth knowing for the key migrations in Restore as many files at a time as the drive does best, with progress #55 / sync: closest devices first, by measured link speed #27.Notes
src/locales/were not touched.zh-CN.json. The open PRs that add keys to it (Restore as many files at a time as the drive does best, with progress #55restoreProgress.*, sync: closest devices first, by measured link speed #27devices.link*) will need those keys moved tozh-Hans/zh-Hant— whichever of us merges second, I'm happy to do the migration.Verification
npm test: 299/299 (catalog completeness both ways, English fallback, placeholder filling, plural categories, script resolution tw/hk/mo → zh-Hant, saved choice > system language > en).vite build: clean.Translation: @Janlhin (simplified & traditional)