Repository navigation
relocate: an offer is stale once the save folder was set by hand - #68
Merged
Omar-VF merged 1 commit intoOct 16, 2026
Merged
Conversation
AcceptRelocation checked that the folder accepted was the one offered, but not that the game was still at the missing path the offer was made for. A folder set by hand while the offer was open was then overwritten by accepting the old offer. The offer now records the path it was made for, and accepting it after the save path changed is refused and drops the offer. (Follow-up asked for on Liquid-co#24.) Test: TestRelocateToOtherDrive_AnOfferIsStaleOnceTheFolderIsSetByHand (fails without this: the hand-set folder is overwritten). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@ChakraFusion is attempting to deploy a commit to the sivadaboi's projects Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Oct 15, 2026
ChakraFusion
pushed a commit
to ChakraFusion/OpenSave
that referenced
this pull request
Oct 16, 2026
Entries for Liquid-co#49, Liquid-co#70, Liquid-co#69, Liquid-co#72, Liquid-co#68 and Liquid-co#47, added at the end of the Fixed list so they do not touch Liquid-co#75's own entry. Liquid-co#57 is test-only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The follow-up asked for on #24.
AcceptRelocationchecked that the folder accepted was the one offered, but not that the game was still at the missing path the offer was made for. A save folder set by hand while an offer was open was then overwritten by accepting the old offer.The offer now records the missing path it was made for (
relocateFor). Accepting it after the game's save path changed is refused with a message saying why, and the stale offer is dropped. The record is cleared wherever an offer ends (accepted, dismissed, or the folder came back).Test:
TestRelocateToOtherDrive_AnOfferIsStaleOnceTheFolderIsSetByHandfails without the change (the hand-set folder is overwritten) and passes with it. The existing relocation tests still pass. CI on my fork is green.🤖 Generated with Claude Code