Skip to content

fix(cloud/local): propagate destination listing errors - #47

Merged
Omar-VF merged 2 commits into
Liquid-co:dev-publicfrom
Seagulls:research/opensave-46-local-listing-20261011
Oct 16, 2026
Merged

Omar-VF merged 2 commits into
Liquid-co:dev-publicfrom
Seagulls:research/opensave-46-local-listing-20261011

Conversation

@Seagulls

@Seagulls Seagulls commented Oct 11, 2026 •

Copy link
Copy Markdown

Refs #46 — partial fix only.

An unavailable or unreadable local-folder destination previously returned
an empty successful listing. This patch propagates the underlying os.ReadDir
error, allowing callers to distinguish a storage failure from an empty backup.

Tests cover absent paths, non-directory destinations and ordinary folders.

The mount-loss fallback-write problem is NOT fixed. Uploads can still create
a missing local directory, and detecting a vanished NAS mount requires a
separate opt-in mount-identity contract.

Based on dev-public at 7b69042.
Research provenance: e4c113f.

Focused cloud tests, race detector and go vet pass.
The backend E2E suite passed during combined-branch validation.
The desktop app was not built because frontend/dist is absent.

@vercel

vercel Bot commented Oct 11, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the sivadaboi's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Omar-VF

Omar-VF commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Thanks for this, and for #44–#46. One request: please move docs/research/CLOUD-LOCAL-46-LISTING.md out of docs/. That folder is the website (opensave.org), so anything in it gets published. The PR description or a comment on #46 is a good place for it instead. CI is approved and running.

@Seagulls

Copy link
Copy Markdown
Author

Thanks — removed the internal research note from docs/ in a86d964. The PR description and #46 retain the scope, provenance, evidence, and the remaining mount-loss limitation. No Go source or test behavior changed. Focused go test, race-enabled tests, and go vet pass.

@Omar-VF
Omar-VF merged commit 7f7588b into Liquid-co:dev-public Oct 16, 2026
10 of 11 checks passed
ChakraFusion pushed a commit to ChakraFusion/OpenSave that referenced this pull request Oct 16, 2026
Entries for Liquid-co#49, Liquid-co#70, Liquid-co#69, Liquid-co#72, Liquid-co#68 and Liquid-co#47, added at the end of the
Fixed list so they do not touch Liquid-co#75's own entry. Liquid-co#57 is test-only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants