hostmot2: check hal_malloc results in sserial and abs_encoder setup - #4633
Merged
Merged
Conversation
The load path dereferenced hal_malloc results without a check. On HAL shared-memory exhaustion, or on a garbage global/conf count read from an unresponsive remote, the next statement wrote through NULL and killed the loading process with no useful message. Fail with -ENOMEM and the channel name instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sserial and abs_encoder load paths dereference hal_malloc results without checking. On HAL shared-memory exhaustion, or on a garbage record count read from an unresponsive remote, the next statement writes through NULL and kills the loading process with no useful message. Fail with -ENOMEM and the channel name instead.
One of three candidates for @andypugh's hostmot2 SIGSEGV on master (see #4453, #4632). Split out of #4626.