homing: drop the dead HOME_DELAY timer in HOME_FINAL_MOVE_START - #4629
Open
grandixximo wants to merge 1 commit into
Open
grandixximo wants to merge 1 commit into
grandixximo wants to merge 1 commit into
Conversation
The timer branch incremented pause_timer, fell through, and zeroed it in the same servo cycle; it has never delayed anything since the 2022 state-machine rework dropped its break (becaf35). The missing delay was reported as a bug (LinuxCNC#4621) and the resolution was to declare the current behavior intended (LinuxCNC#4628, docs updated). Remove the dead code and say in a comment that the absence of HOME_DELAY here is deliberate, so the state no longer reads as an accidental omission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4621 and #4628.
The timer branch in
HOME_FINAL_MOVE_STARTincrementedpause_timer, fell through, and zeroed it in the same servo cycle; it has not delayed anything since the 2022 state-machine rework (becaf35c2f) dropped itsbreak. #4621 reported that as a bug, and the resolution in #4628 was to declare the current behavior intended and fix the developer-manual diagram to match.Thanks @yurc for the careful measurement work in #4621 that pinned down what the code actually does (2 servo periods in the state, not 0.1 s), and for the docs fix.
This PR removes the dead code and leaves a comment stating that the absence of
HOME_DELAYhere is deliberate, so the state no longer reads as an accidental omission that invites another bug report. No behavior change.@andypugh do you agree with settling it this way? The alternative was restoring the 100 ms pause, gated on the joint having moved (yurc's v2 in #4621); my argument there was that nobody missed the delay through four years of 2.9 releases, so docs-match-code was the better landing.