Conversation
The option loop tested "-h" with a plain "if" after the "-e" branch, so "-e" fell through to the "else" and the script exited with "Unhandled option: '-e'" (exit code 2). Use "elif". Reproduce: linuxcnc_check_ini -e any.ini before: Unhandled option: '-e' after: the INI file is checked and warnings are treated as errors.
The INI file only produces a warning. Without -e the exit value must be 0; with -e or --error warnings are errors and the exit value must be 1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RZ9Cy18se5jq3dpFgTetJs
grandixximo
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option loop in
main()tests-hwith a plainifafter the-ebranch, so-e/--errorfalls through to theelseand the script exits withUnhandled option: '-e'(exit code 2). The fix iselif.Reproduce:
Before:
Unhandled option: '-e', exit 2. After: the INI file is checked and warnings are treated as errors;-hstill prints usage.One-line change,
src/emc/ini/linuxcnc_check_ini.pyonly.