hal: Update first batch of C components to use getter/setter - #4310
Merged
Conversation
grandixximo
reviewed
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the first batch of components converted to getter/setter that are partly or in whole written C. There is nothing really wild in the conversion.
Several places have had old hal types replaced with the proper rtapi types. The hal types were being abused as normal variable types, making things unnecessarily slow.
There are several places that could have been optimized or streamlined. Some places it was improved, other places it was not. A future sweep across all components should review them anyway and then can be improved.
The debounce.c component has a possible define to export the state variable as a parameter. It was opted to use the preprocessor to select a hal type or a normal type and add access-functions to wrap read/write to the state. Normally, the EXPORT_STATE is undefined and using a normal variable is faster. Otherwise it would have been unnecessarily slower going though the volatility of hal types.