halcompile: reject declarations that export the same HAL name (2.9 backport) - #4299
Open
tzuohann wants to merge 1 commit into
Open
halcompile: reject declarations that export the same HAL name (2.9 backport)#4299tzuohann wants to merge 1 commit into
tzuohann wants to merge 1 commit into
Conversation
tzuohann
changed the title
tzuohann
force-pushed
the
halcompile-halname-2.9
branch
from
July 31, 2026 01:12
4b25bc7 to
f3f45d9
Compare
Contributor
|
Had a weird CI failure, re-running, @BsAtHome shmem issue in 2.9? |
Contributor
No idea... However, I do not think this should be backported. At least we should have an agreement how this must be done before we can think about backporting. |
A name declared in a .comp file is a C identifier, but it is exported
under a mangled HAL identifier: underscores become dashes and a trailing
dash or period is removed (comp.adoc, HALNAME). check_name_ok() compares
only declared names, so a component declaring both x_y and x_y_ exported
both as x-y. halcompile accepted it and the module failed at loadrt:
HAL: ERROR: duplicate variable 'collide.0.x-y'
collide: rtapi_app_main: Invalid argument (-22)
check_hal_name() rejects that at the offending line and points at the
HALNAME documentation. Functions are tracked separately from pins and
params, which share one namespace in hal_lib.c.
All 119 in-tree .comp files preprocess with no new error and no new
output. tests/halcompile/halname covers the rejection.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
tzuohann
force-pushed
the
halcompile-halname-2.9
branch
from
July 31, 2026 17:13
f3f45d9 to
1e5b086
Compare
tzuohann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.9 backport of #4298.
pin in float my_inputis exported ascomponent.N.my-input— underscores become dashes (comp.adoc, HALNAME).A component that declares both
x_yandx_y_exports both asx-y. halcompile accepts it; the module then fails at loadrt:check_name_ok()only compares declared names.check_hal_name()rejects the collision at the offending line and points at the HALNAME documentation. Functions are tracked separately from pins and params, which share one namespace inhal_lib.c.Docs: NAMES section in the halcompile man page, note under the HALNAME table in comp.adoc. Tests:
tests/halcompile/halname. All 119 in-tree.compfiles preprocess with no new output.Man page there is the tracked troff
docs/man/man1/halcompile.1, not the adoc.🤖 Generated with Claude Code