gtk_mesa_tests: Fix calculation in % - #4217
Open
hdiethelm wants to merge 2 commits into
Open
Conversation
Contributor
I say yes too. |
LinuxCNC#4082 changed the time values from cycles to ns. This broke the calculation of % values and the CPU clock is not needed any more.
hdiethelm
force-pushed
the
fix_gtk_mesa_tests
branch
from
July 25, 2026 11:08
ace34d3 to
a6daed0
Compare
Contributor
Author
|
^Rebased to master |
grandixximo
reviewed
Aug 2, 2026
grandixximo
left a comment
grandixximo
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this. I checked the calculation and it is correct: tmax and period are both in ns from HAL, so the CPU clock is indeed no longer needed.
I built and ran the panel from the branch. Python compiles and the glade file validates, so no blockers from my side.
One nitpick: the two GtkAdjustment objects adj_cpu_speed_nic and adj_cpu_speed_servo at the top of gtk_mesa_tests.glade (lines 4-13) are now orphaned; the spin buttons that referenced them were removed. Please delete them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4082 changed the time values from cycles to ns.
This broke the calculation of % values and the CPU clock is not needed any more.
Discovered here: #4199
TBD: Remove the CPU Speed read fully? I would say yes.