Skip to content

fix(options): request the host permission before reading storage #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Linkid merged 1 commit into from
Jul 9, 2026
+11 −8
Merged

fix(options): request the host permission before reading storage #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions options/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,22 +233,25 @@ async function addInstance() {
}

try {
const instances = await loadInstances()

if (instances.some(i => i.hostname === hostname)) {
showStatus("optionsInstanceExists", "instance-status")
return
}

// the extension may only call the queried API (the review server for
// a Gerrit instance) once the user grants access to its origin
// a Gerrit instance) once the user grants access to its origin.
// permissions.request() must run before any other await, or it loses
// the click's user-activation context and the browser rejects it; an
// already-granted host (the duplicate case) resolves without a prompt.
const granted = await browser.permissions.request(
{ origins: [`*://${permissionHostname(instance)}/*`] })
if (!granted) {
showStatus("optionsPermissionDenied", "instance-status")
return
}

const instances = await loadInstances()

if (instances.some(i => i.hostname === hostname)) {
showStatus("optionsInstanceExists", "instance-status")
return
}

instances.push(instance)
await saveInstances(instances)
document.getElementById("instance-hostname").value = ""
Expand Down