Use protected _validate_initial_state hook#19
Open
jordanplanders wants to merge 1 commit into
Open
Conversation
Rename PBModel.validate_initial_state to a protected hook _validate_initial_state and update its caller in integrate(). Update docstrings to describe the protected hook and that subclasses should override it; base implementation still delegates to the utils/solver helper. In EBM1DLat, switch the override to _validate_initial_state, update docs to reference the new hook, add a numerical-stability note (explicit RK4 diffusion CFL-like limit; with default params use dt ≤ 0.1) and change the example integration dt to 0.1. Also add a guard in the hemisphere-edge detection to propagate NaN (append NaN and continue) when the temperature slice contains NaNs from a diverged integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename PBModel.validate_initial_state to a protected hook _validate_initial_state and update its caller in integrate(). Update docstrings to describe the protected hook and that subclasses should override it; base implementation still delegates to the utils/solver helper.
In EBM1DLat, switch the override to _validate_initial_state, update docs to reference the new hook, add a numerical-stability note (explicit RK4 diffusion CFL-like limit; with default params use dt ≤ 0.1) and change the example integration dt to 0.1. Also add a guard in the hemisphere-edge detection to propagate NaN (append NaN and continue) when the temperature slice contains NaNs from a diverged integration.