Repository navigation
Conversation
…n fields in EventRequest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10
When tracking organic events (such as automatic screen tracking via
LinkFortyNavigatorObserveror direct calls toLinkForty.trackEvent()), event requests to/api/sdk/v1/eventfail with a400 VALIDATION_ERRORon the server.There were two causes in
EventRequest:DateTime.now()used local device time without theZsuffix. Strict backend validators (like Zod.datetime()) reject timestamps that don't end inZ.attributedLinkId,attributedClickId,linkOpenedAt,sessionId) were serialized as explicitnullvalues instead of being left out. The backend validator expects optional strings and rejectsnull.What changed?
.toUtc()inEventRequest's constructor so all timestamps are formatted in ISO 8601 UTC with a trailingZ(matching the pattern already used inattribution_context.dart).EventRequest.toJson()to remove keys withnullvalues before sending, keeping the payload clean and organic events valid.test/models/event_request_test.dartto verify UTCZformatting, timezone conversion, and omission of null attribution fields.How was it tested?
flutter test test/models/event_request_test.dart(all 7 tests passed)flutter test(full suite of 118 tests passed)flutter analyze(no issues found)