fix: remove header/hero gap at specific lg widths#424
Open
vitormattos wants to merge 1 commit into
Open
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
force-pushed
the
fix/header-hero-gap-specific-width
branch
from
d8d4fac to
8a4c2b1
Compare
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--ud-header-heightCSS variable in header styles76pxand adjust to72pxon thelgbreakpoint (992px-1199px)Why
At a specific intermediate desktop width, the fixed header height became
72pxwhile the hero still used a hardcoded76pxtop margin, creating a visible gap between the menu and hero.Validation
1062px: gap went from4pxto0px1200px,1400px,900px: no regression (only subpixel rounding where expected)Scope
source/_assets/scss/_header.scsssource/_assets/scss/_hero.scssbuild_*artifacts