feat: policy signature flow

eslint.config.mjs

@@ -3,11 +3,23 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
+import js from '@eslint/js'
+import { FlatCompat } from '@eslint/eslintrc'
 import nextcloudConfig from '@nextcloud/eslint-config'
-import globals from 'globals'
+import { dirname } from 'node:path'
+import { fileURLToPath } from 'node:url'
+
+const compat = new FlatCompat({
+	baseDirectory: dirname(fileURLToPath(import.meta.url)),
+	recommendedConfig: js.configs.recommended,
+	allConfig: js.configs.all,
+})
+
+const compatConfigs = (Array.isArray(nextcloudConfig) ? nextcloudConfig : [nextcloudConfig])
+	.flatMap((config) => compat.config(config))
 
 export default [
-	...(Array.isArray(nextcloudConfig) ? nextcloudConfig : [nextcloudConfig]),
+	...compatConfigs,
 
 	{
 		name: 'libresign/ignores',

lib/Activity/Provider/SignRequest.php

@@ -83,9 +83,11 @@ public function parse($language, IEvent $event, ?IEvent $previousEvent = null):
 
 	private function getParsedSubject(\OCP\IL10N $l, string $subject) {
 		if ($subject === 'new_sign_request') {
+			// TRANSLATORS Activity message shown to a signer. {from} is the requester name and {file} is the document filename.
 			return $l->t('{from} requested your signature on {file}');
 		} elseif ($subject === 'update_sign_request') {
-			return $l->t('{from} made changes on {file}');
+			// TRANSLATORS Activity message shown when an existing signature request was updated. {from} is the requester name and {file} is the document filename.
+			return $l->t('{from} updated the signature request for {file}');
 		}
 	}
 }

lib/Activity/Provider/SignRequestCanceled.php

@@ -66,6 +66,7 @@ public function parse($language, IEvent $event, ?IEvent $previousEvent = null):
 		$l = $this->languageFactory->get(Application::APP_ID, $language);
 		$parameters = $event->getSubjectParameters();
 
+		// TRANSLATORS Activity message shown when a signature request is canceled. {from} is the requester name and {file} is the document filename.
 		$subject = $l->t('{from} canceled the signature request for {file}');
 		$event->setParsedSubject(
 			str_replace(

lib/Activity/Provider/Signed.php

@@ -84,6 +84,7 @@ public function parse($language, IEvent $event, ?IEvent $previousEvent = null):
 		$l = $this->languageFactory->get(Application::APP_ID, $language);
 		$parameters = $event->getSubjectParameters();
 
+		// TRANSLATORS Activity message shown after a signer completes the document. {from} is the signer name and {file} is the document filename.
 		$subject = $l->t('{from} signed {file}');
 		$event->setParsedSubject(
 			str_replace(

lib/AppInfo/Application.php

@@ -60,7 +60,6 @@ public function register(IRegistrationContext $context): void {
 		$context->registerNotifierService(Notifier::class);
 
 		$context->registerSearchProvider(FileSearchProvider::class);
-
 		$context->registerEventListener(LoadSidebar::class, TemplateLoader::class);
 		$context->registerEventListener(BeforeNodeDeletedEvent::class, BeforeNodeDeletedListener::class);
 		$context->registerEventListener(CacheEntryRemovedEvent::class, BeforeNodeDeletedListener::class);

lib/Capabilities.php

@@ -8,13 +8,13 @@
 
 namespace OCA\Libresign;
 
-use OCA\Libresign\AppInfo\Application;
 use OCA\Libresign\Service\Envelope\EnvelopeService;
+use OCA\Libresign\Service\Policy\PolicyService;
+use OCA\Libresign\Service\Policy\Provider\Confetti\ConfettiPolicy;
 use OCA\Libresign\Service\SignatureTextService;
 use OCA\Libresign\Service\SignerElementsService;
 use OCP\App\IAppManager;
 use OCP\Capabilities\IPublicCapability;
-use OCP\IAppConfig;
 
 /**
  * @psalm-import-type LibresignCapabilities from ResponseDefinitions
@@ -29,7 +29,7 @@ public function __construct(
 		protected SignatureTextService $signatureTextService,
 		protected IAppManager $appManager,
 		protected EnvelopeService $envelopeService,
-		protected IAppConfig $appConfig,
+		protected PolicyService $policyService,
 	) {
 	}
 
@@ -43,7 +43,7 @@ public function getCapabilities(): array {
 		$capabilities = [
 			'features' => self::FEATURES,
 			'config' => [
-				'show-confetti' => $this->appConfig->getValueBool(Application::APP_ID, 'show_confetti_after_signing', true),
+				'show-confetti' => $this->policyService->resolve(ConfettiPolicy::KEY)->getEffectiveValueAsBool(true),
 				'sign-elements' => [
 					'is-available' => $this->signerElementsService->isSignElementsAvailable(),
 					'can-create-signature' => $this->signerElementsService->canCreateSignature(),

lib/Collaboration/Collaborators/AccountPhonePlugin.php

@@ -11,6 +11,7 @@
 use OC\KnownUser\KnownUserService;
 use OCA\Libresign\Service\Identify\SearchNormalizer;
 use OCA\Libresign\Service\Identify\SignerSearchContext;
+use OCA\Libresign\Service\IdentifyMethodService;
 use OCP\Accounts\IAccountManager;
 use OCP\Collaboration\Collaborators\ISearchPlugin;
 use OCP\Collaboration\Collaborators\ISearchResult;
@@ -22,7 +23,6 @@
 
 class AccountPhonePlugin implements ISearchPlugin {
 	public const TYPE_SIGNER_ACCOUNT_PHONE = 51;
-	private const array PHONE_BASED_METHODS = ['whatsapp', 'sms', 'telegram', 'signal'];
 
 	public function __construct(
 		private IAppConfig $appConfig,
@@ -44,7 +44,7 @@ public function search($search, $limit, $offset, ISearchResult $searchResult): b
 		$method = $this->searchContext->getMethod();
 		$search = trim((string)$search);
 
-		if ($search === '' || !in_array($method, self::PHONE_BASED_METHODS, true)) {
+		if ($search === '' || !in_array($method, IdentifyMethodService::IDENTIFY_PHONE_METHODS, true)) {
 			return false;
 		}
 

lib/Collaboration/Collaborators/ContactPhonePlugin.php

@@ -11,6 +11,7 @@
 use OC\KnownUser\KnownUserService;
 use OCA\Libresign\Service\Identify\SearchNormalizer;
 use OCA\Libresign\Service\Identify\SignerSearchContext;
+use OCA\Libresign\Service\IdentifyMethodService;
 use OCP\Collaboration\Collaborators\ISearchPlugin;
 use OCP\Collaboration\Collaborators\ISearchResult;
 use OCP\Collaboration\Collaborators\SearchResultType;
@@ -22,7 +23,6 @@
 
 class ContactPhonePlugin implements ISearchPlugin {
 	public const TYPE_SIGNER_CONTACT_PHONE = 52;
-	private const array PHONE_BASED_METHODS = ['whatsapp', 'sms', 'telegram', 'signal'];
 
 	public function __construct(
 		private IAppConfig $appConfig,
@@ -44,7 +44,7 @@ public function search($search, $limit, $offset, ISearchResult $searchResult): b
 		$method = $this->searchContext->getMethod();
 		$search = trim((string)$search);
 
-		if ($search === '' || !in_array($method, self::PHONE_BASED_METHODS, true)) {
+		if ($search === '' || !in_array($method, IdentifyMethodService::IDENTIFY_PHONE_METHODS, true)) {
 			return false;
 		}
 

lib/Collaboration/Collaborators/ManualPhonePlugin.php

@@ -9,6 +9,7 @@
 namespace OCA\Libresign\Collaboration\Collaborators;
 
 use OCA\Libresign\Service\Identify\SignerSearchContext;
+use OCA\Libresign\Service\IdentifyMethodService;
 use OCP\Collaboration\Collaborators\ISearchPlugin;
 use OCP\Collaboration\Collaborators\ISearchResult;
 use OCP\Collaboration\Collaborators\SearchResultType;
@@ -17,7 +18,6 @@
 
 class ManualPhonePlugin implements ISearchPlugin {
 	public const TYPE_SIGNER_MANUAL_PHONE = 53;
-	private const array PHONE_BASED_METHODS = ['whatsapp', 'sms', 'telegram', 'signal'];
 
 	public function __construct(
 		private IConfig $config,
@@ -34,7 +34,7 @@ public function search($search, $limit, $offset, ISearchResult $searchResult): b
 		$method = $this->searchContext->getMethod();
 		$search = trim((string)$search);
 
-		if ($search === '' || !in_array($method, self::PHONE_BASED_METHODS, true)) {
+		if ($search === '' || !in_array($method, IdentifyMethodService::IDENTIFY_PHONE_METHODS, true)) {
 			return false;
 		}
 

lib/Command/Developer/Reset.php

@@ -96,6 +96,12 @@ protected function configure(): void {
 				mode: InputOption::VALUE_NONE,
 				description: 'Reset config'
 			)
+			->addOption(
+				name: 'policy',
+				shortcut: null,
+				mode: InputOption::VALUE_NONE,
+				description: 'Reset policy data'
+			)
 		;
 	}
 
@@ -140,6 +146,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 				$this->resetConfig();
 				$ok = true;
 			}
+			if ($input->getOption('policy') || $all) {
+				$this->resetPolicy();
+				$ok = true;
+			}
 		} catch (\Exception $e) {
 			$this->logger->error($e->getMessage());
 			throw $e;
@@ -254,4 +264,23 @@ private function resetConfig(): void {
 		} catch (\Throwable) {
 		}
 	}
+
+	private function resetPolicy(): void {
+		try {
+			$delete = $this->db->getQueryBuilder();
+			$delete->delete('libresign_permission_set_binding')
+				->executeStatement();
+
+			$delete = $this->db->getQueryBuilder();
+			$delete->delete('libresign_permission_set')
+				->executeStatement();
+
+			$delete = $this->db->getQueryBuilder();
+			$delete->delete('preferences')
+				->where($delete->expr()->eq('appid', $delete->createNamedParameter(Application::APP_ID)))
+				->andWhere($delete->expr()->like('configkey', $delete->createNamedParameter('policy.%')))
+				->executeStatement();
+		} catch (\Throwable) {
+		}
+	}
 }