fix: await upload session registration - #50
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8a32604f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
I fixed the upload authorization race that could register files under unusable
upload:null...keys by making Redis session registration a strict prerequisite for file-server forwarding.SETbefore every/uploadPUT./upload/batchso every file waits for the same completed write.Fixes #40
Change Type
Testing
cd service && bun run build.cd service && bun run test: 523 tests passed.cd service && bun test src/service/upload-session.test.ts --rerun-each 20: 60 repeated tests passed.Test Configuration:
Checklist