Repository navigation
build: ship an empty tpl_c directory in the release - #1978
Merged
Merged
Conversation
The release build left out tpl_c/*.*, which only matches files directly in tpl_c. Compiled templates in a subdirectory, such as the ones Twig will keep in tpl_c/twig, would have been packaged. Leave out everything under tpl_c instead and create the empty directory in the staging area. The installer checks that tpl_c is writable but never creates it, and nothing under tpl_c is tracked in git, so a release built from a fresh clone had no tpl_c at all. Assisted-by: Claude:claude-fable-5-2
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are present, and the packaging changes address both cache exclusion and inclusion of a writable empty directory for fresh installations.
No open issues 🎉
What changed in this PR
Updates the release packaging process so compiled template caches are excluded while an empty writable tpl_c directory is included for fresh installations.
Changes:
- Excludes all contents under
tpl_c, including nested directories. - Creates an empty
tpl_cdirectory in the staging area before packaging.
| File | Description |
|---|---|
| build.xml | Adjusts release staging exclusions and creates the required empty tpl_c directory. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release build left out tpl_c/., which only matches files directly in tpl_c. Compiled templates in a subdirectory, such as the ones Twig will keep in tpl_c/twig, would have been packaged.
Leave out everything under tpl_c instead and create the empty directory in the staging area. The installer checks that tpl_c is writable but never creates it, and nothing under tpl_c is tracked in git, so a release built from a fresh clone had no tpl_c at all.
Assisted-by: Claude:claude-fable-5-2