Skip to content

build: ship an empty tpl_c directory in the release - #1978

Merged
JohnVillalovos merged 1 commit into
mainfrom
jlvillal/phing
Nov 19, 2026
Merged

JohnVillalovos merged 1 commit into
mainfrom
jlvillal/phing

Conversation

@JohnVillalovos

Copy link
Copy Markdown
Collaborator

The release build left out tpl_c/., which only matches files directly in tpl_c. Compiled templates in a subdirectory, such as the ones Twig will keep in tpl_c/twig, would have been packaged.

Leave out everything under tpl_c instead and create the empty directory in the staging area. The installer checks that tpl_c is writable but never creates it, and nothing under tpl_c is tracked in git, so a release built from a fresh clone had no tpl_c at all.

Assisted-by: Claude:claude-fable-5-2

The release build left out tpl_c/*.*, which only matches files
directly in tpl_c. Compiled templates in a subdirectory, such as the
ones Twig will keep in tpl_c/twig, would have been packaged.

Leave out everything under tpl_c instead and create the empty
directory in the staging area. The installer checks that tpl_c is
writable but never creates it, and nothing under tpl_c is tracked in
git, so a release built from a fresh clone had no tpl_c at all.

Assisted-by: Claude:claude-fable-5-2

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are present, and the packaging changes address both cache exclusion and inclusion of a writable empty directory for fresh installations.

No open issues 🎉

What changed in this PR

Updates the release packaging process so compiled template caches are excluded while an empty writable tpl_c directory is included for fresh installations.

Changes:

  • Excludes all contents under tpl_c, including nested directories.
  • Creates an empty tpl_c directory in the staging area before packaging.
File Description
build.xml Adjusts release staging exclusions and creates the required empty tpl_c directory.

Review effort: Lite

@JohnVillalovos
JohnVillalovos enabled auto-merge (rebase) November 19, 2026 02:34
@JohnVillalovos
JohnVillalovos merged commit ef8f9cf into main Nov 19, 2026
16 checks passed
@JohnVillalovos
JohnVillalovos deleted the jlvillal/phing branch November 19, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants