Skip to content

Fix missing icon in MaterialDesign v2 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmurmur merged 1 commit into from
Jul 29, 2026
Merged

Fix missing icon in MaterialDesign v2 #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/com/portalmedia/embarc/gui/ValidationWarningHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public static HBox setInvalidRuleSets(Set<ValidationRuleSetEnum> invalidRuleSet)
icon.setIconSize(16);
warningIcons.getChildren().add(icon);
} else if (rule == ValidationRuleSetEnum.FADGI_SR) { // red octagon
final FontIcon icon = new FontIcon(MaterialDesign.MDI_ALERT_OCTAGON);
final FontIcon icon = new FontIcon(FontAwesomeSolid.EXCLAMATION_CIRCLE);
icon.getStyleClass().add("fadgi-sr-warning");
icon.setIconSize(18);
warningIcons.getChildren().add(icon);
Expand Down Expand Up @@ -128,7 +128,7 @@ public static boolean getInvalidRuleSetsAndUpdateErrorIcons(
}

hasInvalidRules = true;
final FontIcon icon = new FontIcon(MaterialDesign.MDI_ALERT_OCTAGON);
final FontIcon icon = new FontIcon(FontAwesomeSolid.EXCLAMATION_CIRCLE);
icon.setAccessibleText(ruleText);
icon.getStyleClass().add("fadgi-sr-warning-clickable");

Expand Down
4 changes: 2 additions & 2 deletions src/main/com/portalmedia/embarc/gui/ValidationWarningIcons.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public void setInvalidRuleSets(Set<ValidationRuleSetEnum> invalidRuleSet) {
icon.setIconSize(16);
warningIcons.getChildren().add(icon);
} else if (rule == ValidationRuleSetEnum.FADGI_SR) { // red octagon
final FontIcon icon = new FontIcon(MaterialDesign.MDI_ALERT_OCTAGON);
final FontIcon icon = new FontIcon(FontAwesomeSolid.EXCLAMATION_CIRCLE);
icon.getStyleClass().add("fadgi-sr-warning");
icon.setIconSize(18);
warningIcons.getChildren().add(icon);
Expand Down Expand Up @@ -119,7 +119,7 @@ public void setInvalidRuleSets(Set<ValidationRuleSetEnum> invalidRuleSet, Column
}
}
}
final FontIcon icon = new FontIcon(MaterialDesign.MDI_ALERT_OCTAGON);
final FontIcon icon = new FontIcon(FontAwesomeSolid.EXCLAMATION_CIRCLE);
icon.setAccessibleText(ruleText);
icon.getStyleClass().add("fadgi-sr-warning");
final Tooltip tt = new Tooltip(ruleText);
Expand Down
2 changes: 1 addition & 1 deletion src/main/com/portalmedia/embarc/gui/dpx/RuleSetModalController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public void changed(ObservableValue<? extends Boolean> obs, Boolean ov, Boolean
// FADGI-SR - red octagon
final CheckBox fadgiSRCheckbox = new CheckBox("FADGI-SR");
fadgiSRCheckbox.setStyle(alertTextStyles);
final FontIcon icon3 = new FontIcon(MaterialDesign.MDI_ALERT_OCTAGON);
final FontIcon icon3 = new FontIcon(FontAwesomeSolid.EXCLAMATION_CIRCLE);
icon3.getStyleClass().add("fadgi-sr-warning");
icon3.setIconSize(18);
fadgiSRCheckbox.setGraphic(icon3);
Expand Down
2 changes: 1 addition & 1 deletion src/main/com/portalmedia/embarc/gui/dpx/WriteFilesView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ public void setMessage(SectionDef section) {
fsrCB.setId("FADGI_SR");
final Label fsrLabel = new Label("Files with FADGI-SR violations"); // red octagon
fsrLabel.setLabelFor(fsrCB);
final FontIcon icon1 = new FontIcon(MaterialDesign.MDI_ALERT_OCTAGON);
final FontIcon icon1 = new FontIcon(FontAwesomeSolid.EXCLAMATION_CIRCLE);
icon1.getStyleClass().add("fadgi-sr-warning");
icon1.setIconSize(18);
fsrLabel.setGraphic(icon1);
Expand Down
2 changes: 1 addition & 1 deletion src/main/com/portalmedia/embarc/gui/mxf/ValidationCellFactoryMXF.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ protected void updateItem(String item, boolean empty) {
final MXFFileInformationViewModel fivm = row.getItem();
String cellData = columnData.getCellData(fivm);
if (mcvmData.getMXFColumn().isRequired() && StringUtils.isBlank(cellData)) {
final FontIcon icon = new FontIcon(MaterialDesign.MDI_ALERT_OCTAGON);
final FontIcon icon = new FontIcon(FontAwesomeSolid.EXCLAMATION_CIRCLE);
icon.setAccessibleText("Missing Required Value");
icon.getStyleClass().add("fadgi-sr-warning");

Expand Down
2 changes: 1 addition & 1 deletion src/main/com/portalmedia/embarc/gui/mxf/ValidationChangeListenerMXF.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public void changed(ObservableValue<? extends String> ov, String oldValue, Strin

public void setMissingRequiredField(String value) {
if (this.column.isRequired() && StringUtils.isBlank(value)) {
final FontIcon icon = new FontIcon(MaterialDesign.MDI_ALERT_OCTAGON);
final FontIcon icon = new FontIcon(FontAwesomeSolid.EXCLAMATION_CIRCLE);
icon.getStyleClass().add("fadgi-sr-warning");
validationInfo.getChildren().add(icon);
textField.setAccessibleText("Missing Required Value");
Expand Down
Loading