CMake: don't export turbojpeg symbols#730
Open
net147 wants to merge 1 commit into
Open
Conversation
If an application links to both libvncserver and libjpeg-turbo (either directly or indirectly through another library), it can cause the application to unexpectedly call the libvncserver implementation instead of the libjpeg-turbo implementation. Avoid this by not exporting the turbojpeg symbols. Fixes LibVNC#729
bk138
requested changes
Jun 17, 2026
| ) | ||
|
|
||
| if(UNIX) | ||
| set_source_files_properties(${COMMON_DIR}/turbojpeg.c PROPERTIES COMPILE_OPTIONS "-fvisibility=hidden") |
Member
There was a problem hiding this comment.
this is relying on compiler flags, there must be a CMake way, like PRIVATE linkage ...
|
Hm. I'm a bit confused as to why this source even exists here. My best understanding, libvncserver requires TurboJPEG API, but doesn't want to hard-require libjpeg-turbo itself, so instead if also supports generic libjpeg and has an old copy of libjpeg turbo's sources to build it's own. Options as I see it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an application links to both libvncserver and libjpeg-turbo (either directly or indirectly through another library), it can cause the application to unexpectedly call the libvncserver implementation instead of the libjpeg-turbo implementation.
Avoid this by not exporting the turbojpeg symbols.
Fixes #729