nvme: Fix feature dispatch, flush status, log page and namespace ID validation - #323
Open
BeastLe9enD wants to merge 4 commits into
Open
BeastLe9enD wants to merge 4 commits into
BeastLe9enD wants to merge 4 commits into
Conversation
The dispatch compared the opcode against Delete IO CQ, so every Set Feature command was handled as Get Feature.
Flush always completed successfully even when synchronizing the backing store failed.
Get Log Page copied a whole page regardless of the requested dword count and ignored the log page offset. Reject requests that do not fit into the page and copy only the requested range.
Identify and IO commands accepted any namespace ID. Return Invalid Namespace for IO and namespace descriptor requests on unknown namespaces, report an empty structure for unknown namespaces in Identify Namespace, and only list namespace 1 when the requested start lies below it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four independent fixes in the NVMe controller, one commit each:
used
NVME_ADM_DELETE_IO_CQinstead ofNVME_ADM_SET_FEATURE.rvvm_blk_sync()failed. Return a data transfer error in that case.
and always copied a full page. Validate both against the page size
and copy only the requested range.
Namespace for IO and namespace-descriptor requests on unknown
namespaces, a zeroed structure for Identify Namespace, and only list
namespace 1 when the requested start lies below it.