Steam launch options: accept env-style args without %command% (all stores) - #5
Open
Leb-Sun wants to merge 1 commit into
Open
Steam launch options: accept env-style args without %command% (all stores)#5Leb-Sun wants to merge 1 commit into
Leb-Sun wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
%command%requirement Nick raised: a plain env-style launch option likeWINEDLLOVERRIDES=D3D12=dorDXVK_HUD=FPSnow applies without appending%command%,and behaves consistently across Steam / Epic / GOG / Custom.
What changed (2 files, +40/−1):
SteamLaunchOptions.parse()— with no%command%, a leading run of UPPERCASEKEY=VALUEtokens is read as env vars (shell-style prefix); the first non-env token onward stays game
args, kept verbatim (quotes preserved). The
%command%branch is untouched, so existingX=Y %command% argsstrings behave exactly as before.XServerDisplayActivity— Epic/GOG/Custom now route their exec args throughSteamLaunchOptions.gameArgs()like the Steam path already does, so%command%/env tokensstop leaking into the game's argv (cross-store parity).
Behavior:
WINEDLLOVERRIDES=D3D12=d,DXVK_HUD=FPS,DXVK_HUD=FPS -windowed→ env applied, no%command%.-dx11,+connect, lowercasekey=value→ stay game args (uppercase-guarded, so real customargs aren't swallowed).
WINEDLLOVERRIDES="winhttp=n,b" %command%(pasted mod/protondb command) → unchanged.Known edge (accepted): an UPPERCASE
KEY=VALUEthat is genuinely a game argument, typedwith no
%command%, would be read as env — rare;%command% KEY=valforces it back to an arg.Cut from upstream
main; opened against my ownmainto trigger a build and track it separately(no upstream PR yet).