You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(api): assert the RI exchange quote and execute library requests - #1916
Slice 2 of #1907: round-trip tests for the RI exchange quote (POST /api/ri-exchange/quote) and execute (POST /api/ri-exchange/execute) bodies. The existing tests asserted the audit row or the converter, not the request the handler hands to the exchange library.
Each test sends a full body in both shapes (the targets array and the legacy target_offering_id and target_count) and asserts every field of the library request: region, source RI ids, targets, legacy offering and count, and the execute spend cap. Test-only, no production change.
Verification
14 mutants (each field assignment removed from the two library-request literals, plus value mutants) all fail the new tests; none was a build failure.
Pinned golangci-lint v2.10.1: 0 issues; go test ./internal/mocks/ passes.
Added coverage for exchange execution and quote requests, verifying that supplied target, region, payment-cap, and legacy request fields are forwarded and remain distinct. This helps catch inconsistencies in how request details are handled.
The execute and quote tests asserted the audit row or only the converter, so a
body field dropped before the exchange library call would go unnoticed. Send
a full body in both shapes (targets array and the legacy singleton fields) and
assert every field of the request the handler hands to the library.
Part of #1907
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
No actionable comments were generated in the recent review.
Walkthrough
This pull request adds tests that capture the requests passed by executeExchange and getExchangeQuote to the exchange library. The tests check array-target and legacy-singleton fields, including region and payment cap where supplied.
Changes: Exchange request forwarding
Layer / File(s)
Summary
Verify execute and quote request forwarding internal/api/handler_ri_exchange_execute_roundtrip_test.go
Adds capture tests for both handlers. The tests check array-target fields, separate legacy fields, and that legacy fields are not converted to Targets.
LeanerCloud/cloud-commitments-platform#1907 — The issue identifies missing round-trip tests for quote and execute request bodies at the library boundary. This pull request adds those tests.
The new request-forwarding tests can reach their assertions. No issue identified here needs resolution before merging.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly identifies the API tests that verify exchange quote and execute library requests.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cristim
added
impact/internal
What
Slice 2 of #1907: round-trip tests for the RI exchange quote (
POST /api/ri-exchange/quote) and execute (POST /api/ri-exchange/execute) bodies. The existing tests asserted the audit row or the converter, not the request the handler hands to the exchange library.Each test sends a full body in both shapes (the
targetsarray and the legacytarget_offering_idandtarget_count) and asserts every field of the library request: region, source RI ids, targets, legacy offering and count, and the execute spend cap. Test-only, no production change.Verification
go test ./internal/mocks/passes.Part of #1907
🤖 Generated with Claude Code
Summary by CodeRabbit