Repository navigation
docs(audit): add the API adapter audit (#19) - #1909
Merged
Merged
Conversation
The plan term, payment and target_coverage rows reach the target only when provider and service are both set; say so. Name the six strict decoders and note that the ladder config decode is covered by the follow-up issue. Part of #19 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
cristim
added
priority/p2
Contributor
|
Important Review skippedReview was skipped because the changed files are too large to review. 📏 Files whose diffs exceed the per-file size limit: 1
Retrying the review will skip these files again. If they are generated content such as fixtures or snapshots, exclude them with
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
docs/audits/api-adapter-audit-2026-11-09.md, the written adapter audit #19 asks for: for every API request adapter (request type plus handler call path) which fields reach their target and which are accepted and dropped, an appendix of all 64 decode sites at the audited commit, a test-coverage table, and how the existing guards keep it true. The doc states the method's limits.Findings are fixed (#1788, #1905, #1906), already tracked (#1776, #923), or collected in the follow-up issue #1907.
The doc is committed in five commits of at most 315 added lines each, so the PR is merged with a rebase to keep that split on main.
Verification
git grep -n -E '(Unmarshal|Decode)\(' 72d90d54 -- internal/api internal/server ':!*_test.go'(64 lines): identical.Closes #19
🤖 Generated with Claude Code