Skip to content

fix(email): SMTP scheduled-purchase notification goes to NOTIFY_EMAIL instead of the approver #1590

Closed

Description

@IAmJSD

SMTPSender.SendScheduledPurchaseNotification (internal/email/smtp_sender.go, ~line 475) sends the "Purchase Scheduled" email, which includes the purchase's cancel link, to the shared NOTIFY_EMAIL address. #111 moved the other per-purchase emails to the approver or the plan's recipients. This one was missed, and it isn't one of #111's listed items.

Fix: send it to the same recipients as the other per-purchase emails (the approver or the plan's notification list), as the other senders do since #1275. Add a test that asserts the recipient.

Split out of #111 when closing it.

Activity

  1. cristim commented on Nov 4, 2026

    @cristim
    Member

    Claimed by orchestrator run 2026-11-04 (platform-burndown). The plan has passed two adversarial review passes; implementation follows in a PR that closes this issue.

  2. cristim commented on Nov 4, 2026

    @cristim
    Member

    Fixed by #1671, merged as d868820. The SMTP sender now delivers the scheduled-purchase notice to the configured recipient (plus CC), like the SES sender, and returns ErrNoRecipient when none is set. Verified against a real Mailpit SMTP server: the notice reached the global notification address (main sent it to the notify inbox). Release note: deployments whose NOTIFY_EMAIL differs from the global notification address will now get these notices at the global address.

  3. added a commit that references this issue on Nov 4, 2026
    d868820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions