chore(build): Makefile.terraform targets still use the old per-profile layout; Dependabot doesn't cover docker-compose #1572
Description
What happens
Makefile.terraform's validate, state-list and state-show targets still build terraform/environments/<provider>/<profile>, a per-profile directory layout that no longer exists. The environments are flat per-provider roots (terraform/environments/<provider>) with -var-file and -backend-config per profile. #1566 moved scripts/tf-deploy.sh to the flat layout but left these Makefile targets, so they fail with a missing directory.
Separately, Dependabot doesn't cover docker-compose.yml, so the image digests #1566 pinned (nginx, pgadmin4) won't be bumped automatically.
Proposal
- Point the three Makefile targets at
terraform/environments/<provider>with the profile's tfvars and backend file, the same wayscripts/tf-deploy.shdoes after chore(ci): scan the AWS root in the trivy hook, pin Terraform in one file, fix tf-deploy.sh and make complexity (#349) #1566, and give each profile its ownTF_DATA_DIR. - Add a
docker-composeentry to.github/dependabot.ymlfor the repo root.
Acceptance criteria
make -n -f Makefile.terraform validate PROVIDER=aws PROFILE=dev(and the state targets) reference only existing paths; a gate test covers it.- Dependabot config lists the docker-compose ecosystem.
Filed by IAmJSD's agent at IAmJSD's request (acting owner while the maintainers are away).
Activity
cristim commentedon Nov 5, 2026
Triaged (p3, as labelled). Internal tooling only: three Makefile.terraform targets point at the removed per-profile layout, and Dependabot misses docker-compose.yml. Small and independent.
cristim commentedon Nov 12, 2026
Claimed by claude-platform. Premise checked on origin/main: validate, state-list and state-show in Makefile.terraform:119-132 still use terraform/environments/$(PROVIDER)/$(PROFILE); scripts/tf-deploy.sh (ENV_DIR, PROFILE_FILE, BACKEND_FILE, TF_DATA_DIR) is the flat-layout reference. Plan: mirror tf-deploy.sh in the three targets, add the docker-compose Dependabot entry, and add a gate test that make -n references only existing paths.
ci(make): run the terraform target test in CI