Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,26 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/).

### Notices

- **Azure savings plan inventory fails closed for Shared plans billed to a
billing account (#272).** `savingsplans.Client.GetExistingCommitments` and
`GetCoveringCommitments` (the one the duplicate check reads) list plans
billed to `/subscriptions/<client subscription>`, plus
billing-account-billed Single-scope plans whose applied scope names exactly
the client subscription. A billing-account plan with Shared, management
group or unresolvable scope cannot be attributed to one subscription, so the
whole call returns an error starting "incomplete savings plan inventory for
subscription ..., page N: row M: " (for example "billing-account plan is
not single-subscription scoped", or a "single-scope plan ..." message when a
Single scope cannot be resolved) instead of a partial list. The duplicate
check therefore sees an error, not a silently incomplete inventory, and no
recommendation is purchased on top of a plan it could not see. This affects
EA and MCA tenants that buy savings plans at billing-account scope with
Shared applied scope. Workaround: buy Single-scope plans attributed to the
subscription. A consumer that catches the error and skips Azure savings
plan inventory also removes the duplicate-purchase guard for that
subscription, so it can buy on top of the Shared plan it could not see; only
do that where no Shared billing-account plan can cover the subscription.
Tracked in #272; revisit when a tenant needs Shared attribution.
- **Azure Redis purchases must go through managedredis (`ServiceMemoryDB`).**
The Azure recommendations adapter still labels Redis recommendations
`ServiceCache`, and the cache client now refuses every purchase (#538), so
Expand Down
Loading