[cristim]

Summary

• Wrong current password on profile update now returns HTTP 401 with "Current password is incorrect" instead of a generic 500
• Duplicate email on profile update now returns HTTP 409 with "Unable to update email" -- privacy-safe, does not confirm another account's existence (prevents enumeration)
• New ErrCurrentPasswordIncorrect sentinel added; updateUserEmail fixed to return ErrEmailInUse sentinel instead of a plain string
• New mapProfileUpdateError handler maps both sentinels to the correct status code and message
• Handler tests added for both error paths; service-layer tests assert errors.Is on both sentinels

Closes #929

Test plan

• go test ./internal/auth/... -- TestService_UpdateUserProfile subtests "wrong current password" and "duplicate email returns ErrEmailInUse sentinel" pass
• go test ./internal/api/... -- TestHandler_updateProfile_WrongCurrentPassword (expects 401) and TestHandler_updateProfile_DuplicateEmail (expects 409 with "Unable to update email") pass
• go build ./... succeeds
• Full suite go test ./internal/... -- all 4283 tests pass
• Manual: profile update with wrong current password surfaces "Current password is incorrect" in UI toast instead of "Internal server error"
• Manual: profile update with a taken email address surfaces "Unable to update email" in UI -- does NOT say "already in use"

[coderabbitai]

Warning

Review limit reached

@cristim, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 31 minutes and 24 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 94a84d85-04fe-43e7-a8c0-30ad9b20b2c1

📥 Commits

Reviewing files that changed from the base of the PR and between 56a7797 and 2cfae43.

📒 Files selected for processing (5)

• internal/api/handler_auth.go
• internal/api/handler_auth_test.go
• internal/auth/errors.go
• internal/auth/service_user.go
• internal/auth/service_user_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/profile-update-error-messages

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cristim]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.